317106 - Corrections to Firefox "it" localization

Status: VERIFIED FIXED

(Mozilla Localizations :: it / Italian, defect)

Description

[Michele Dal Corso]

We found that the Connection window in Firefox 1.5 for Mac should be enlarged. The window is still usable but it looks odd. Is still possible to correct this?

Thanks!

Comment 1

[Michele Dal Corso]

Attachment: Patch to enlarge Connection window in Mac Firefox

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 203633 [details] [diff] [review]
Patch to enlarge Connection window in Mac Firefox

This is likely 1.5.1 material, please re-request approval once that is on the plate.

Comment 3

[Michele Dal Corso]

Attachment: Patch to enlarge Connection window in Mac Firefox and a correction to a mispelled word

New patch (Mac corrected connection window size and a correction to a mispelled word) for approval to Firefox 1.5.0.1 release.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 206254 [details] [diff] [review]
Patch to enlarge Connection window in Mac Firefox and a correction to a mispelled word

There hasn't been any opening for the 1.5.0.1 check-ins anywhere, please don't add noise while we try to get tb1.5 out the door.

Comment 5

[Michele Dal Corso]

Attachment: Patch to Mac connection window size, a mispelled Word and a bad translated language

I updated the patch with an error found in the charset selector menu: Hindi language was erroneusly translated with "Indù".

This patch should have a minimum l10n impact. When it will be announced by Axel I will ask l10n approval.

Comment 6

[Michele Dal Corso]

Requesting approval for Firefox 1.5.0.3.

Summary of the path

This patch corrects 3 problems in 3 files:

 - /dom/chrome/charsetTitles.properties
   "Hindi" language erroneously translated. This is an embarassing bug.

 - /browser/chrome/browser/preferences/connection.dtd
   corrects the window size of Connection window in Firefox for Mac.
   This is a minor bug.

 - /toolkit/chrome/mozapps/extensions/extensions.properties
   corrects a mispelled word.

The impact of this patch should be minimum.

Thanks

Comment 7

[Axel Hecht [:Pike]]

Could you attach a screenshot for the mac problem, possible of the fixed one, too?

Comment 8

[Axel Hecht [:Pike]]

oops, bugzilla was right about the override this time, sorry.

Comment 9

[Michele Dal Corso]

Attachment: Mac connection window with wrong size

Comment 10

[Michele Dal Corso]

Attachment: Mac connection window corrected

Comment 11

[Michele Dal Corso]

As requested I attached the screenshot of uncorrected window size:
https://bugzilla.mozilla.org/attachment.cgi?id=219127

and with the corrected size:
https://bugzilla.mozilla.org/attachment.cgi?id=219129

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 206759 [details] [diff] [review]
Patch to Mac connection window size, a mispelled Word and a bad translated language

Did you mean approval-l10n rather than approval1.8.0.3?

Comment 13

[Michele Dal Corso]

I followed these instructions of Axel (from l10n newsgroup):

> To get bugs and patches on our radar, please request [1] blocking1.8.0.3
> on the bug, and request approval1.8.0.3 on the patches. Give a rationale
> for what the change fixes, and as the approval folks for the release
> can't read your language, in some cases a screenshot does good.

were he requests approval1.8.0.3 on the patch. Is this wrong?

Comment 14

[Axel Hecht [:Pike]]

dbaron, yes, it's 1.8.0.3 flags instead of approval-l10n. I re-emphasized that
in the newsgroup, including the rationale (short, only work on one flag, the
release team is going to do the l10n-specific approval requests, too).

Comment 15

[Axel Hecht [:Pike]]

I'd to see Roberto wanting the toolkit/dom changes, too.
This will require a sign-off of Thunderbird 1.5.0.3 it, if we take it.

Comment 16

[Roberto Principiano]

changes are OK for me too

Comment 17

[Jay Patel [:jay]]

Comment on attachment 206759 [details] [diff] [review]
Patch to Mac connection window size, a mispelled Word and a bad translated language

a=jay per triage

Comment 18

[Michele Dal Corso]

Whitch CVS tag should I use to do the correct checkin for the involved files?

Thank you

Comment 19

[Axel Hecht]

hrm. do not re-request blocking. That's just causing pain for those that can
actually + that flag :-(

The right branch tag is MOZILLA_1_8_0_BRANCH.

Comment 20

[Michele Dal Corso]

Checked into CVS

Comment 21

[Francesco Lodolo [:flod]]

I've just verified the latest Mac build: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; it; rv:1.8.0.2) Gecko/20060422 Firefox/1.5.0.2

Changes are ok.

Comment 22

[Roberto Principiano]

Bug verified

Comment 23

[Axel Hecht [:Pike]]

Please test the fixes on recent 1.8.0 nightlies and add the fixed1.8.0.3 keyword
if this bug is fixed for those.

Comment 24

[Michele Dal Corso]

Verified in a recent 1.0.8 nightly

Comment 25

[Tim Riley [:timr]]

Michele-  Did you really mean 1.0.8 nightly?  We were looking for verification on 1.8.0 or now on the 1.5.0.4 RC3 candidiate.

Roberto-  Where did you verify this bug fix?  Was it on the 1.8.0 branch?

Comment 26

[Michele Dal Corso]

(In reply to comment #25)
> Michele-  Did you really mean 1.0.8 nightly?  We were looking for verification
> on 1.8.0 or now on the 1.5.0.4 RC3 candidiate.

Yes, sorry! I verified the fix also in 1.5.0.4 RC4 candidates.