317243 - Can't provide link to query for a portion of a whine

Status: NEW

(Bugzilla :: Whining, enhancement)

Description

[timeless]

i(timeless@bemail)'ve configured a whine for another user (timeless@gmail)

      Email subject line:
Bugs that might be ready for checkins
      Descriptive text sent within whine message:
This is a list of bugs that might be ready for checkins

        Schedule:
              Interval
Friday at 16:00
                Mail to
User [e-mail]

        Queries:
Sort
Search
Title
0 Ready
bugs with patches with r+sr
[ ] One message per bug

0 Ready (Locked)
bugs with patches with r in components that don't need sr
[ ] One message per bug

The resulting email that timeless@gmail receives does not include the names of the queries (this is fine) or any way to run them (this is questionable)

expected results:
some way to include: %queryurl% in the Title fields, e.g.:
<a href="%queryurl%">bugs</a> with patches with r+sr

note that i don't want to force people to do this or to force all whines to include this, but i do want to be able to do this. making people fill in the query url is mean and would require them to change their whines if they change their queries.

Comment 1

[A. Karl Kornel]

I can give you something close:

<a href="%queryurl%">bugs with patches with r+sr</a>

I'm not going to parse the title to determine which words should be linked and which should not.

Otherwise, I'll agree with a caveat: I want to have all extra crud removed from search URLs.  Otherwise this is going to look ugly in the plain text form of the message.

Comment 2

[Max Kanat-Alexander]

(In reply to comment #1)
> Otherwise, I'll agree with a caveat: I want to have all extra crud removed 
> from search URLs. 

  The search URLs for a Saved Search are generally very short.

Comment 3

[timeless]

you can't use saved searches, i'm whining at a different person, see comment 0.

to be clear, i don't want you parsing the urls to determine linkification,

i want $message =~ s/\%queryurl\%/$queryurl/g;
i want to be able to do: <textarea>%queryurl%</textarea> or <input value="%queryurl%"> or anything else.

Comment 4

[Bernd Kuemmerlen]

This has also been requested by our users: It is very disturbing to not be able to run the query from a whine which was sent by a different person. Is there any progress on this or idea how this could be implemented?

Comment 5

[timeless]

Attachment: untested

this doesn't actually give queryurl, but it gives something fairly close. i wonder if there's some function which lets you do general substitutions, because urlbase and stuff would be handy....

Comment 6

[Frédéric Buclin]

FYI, something went wrong while I was reviewing this patch yesterday. Nothing related to this patch (don't worry) but a problem with whine.pl not sending any email. I will finish this review as soon as I can understand what is going wrong (or if it's me only doing something wrong).

Comment 7

[Frédéric Buclin]

Comment on attachment 267895 [details] [diff] [review]
untested

>+        $thisquery->{'title'} =~ s/\%recipient\%/$args->{'recipient'}/g;
>+        $thisquery->{'title'} =~ s/\%author\%/$args->{'author'}/g;

recipient and author are both user objects and so you get stuff like Bugzilla::User=HASH(0x8bc561c) in your email.

Comment 8

[timeless]

Attachment: untested

Comment 9

[Frédéric Buclin]

Comment on attachment 273639 [details] [diff] [review]
untested

>+        $thisquery->{'title'} =~ s/\%($users)(?:\.($properties)|)\%/$args->{$1}->{$2 || 'identity'}/g;
>+        $thisquery->{'title'} =~ s/\%urlquerypart\%/$urlquerypart/g;

\%($users)(?:\.($properties)|)\% accepts %author.%, which is incorrect. Better is to write (?:\.($properties))?.

Comment 10

[timeless]

(In reply to comment #9)
> \%($users)(?:\.($properties)|)\% accepts %author.%, which is incorrect.

It does no such thing. unless $properties begins/ends in |

Comment 11

[Frédéric Buclin]

Comment on attachment 273639 [details] [diff] [review]
untested

>+        $thisquery->{'title'} =~ s/\%($users)(?:\.($properties)|)\%/$args->{$1}->{$2 || 'identity'}/g;

This substitution seems broken. %author.email% and %recipient% do not work. I didn't try any other combination. And many errors are thrown due to this line:

Use of uninitialized value in substitution iterator at ./whine.pl line 460.


>+        $thisquery->{'title'} =~ s/\%urlquerypart\%/$urlquerypart/g;

This one seems to work though. But note that the URL doesn't appear linkified in HTML whine mail, making it rather useless.



>Index: docs/xml/using.xml

>+            If you use whine at others, you may want to use some pronouns in

Why whine at others only?


>+            each search title, you can use: "%urlquerypart%" to let
>+            "%recipient%" construct and run "%author%"'s query.

I don't understand this sentence.


>+            If you'd prefer to use a variant of recipient/author, you can
>+            append any of name, emaoil, login, nick or identity e.g.:

s/emaoil/email/.