317345 - nsLocalFile(OSX)::IsHidden is broken garbage

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Mark Mentovai]

In nsLocalFileOSX.cpp, nsLocalFile::IsHidden returns whatever it feels like returning, without regard for whether a file is actually hidden or not.  The call to FSGetCatalogInfo requests kFSCatInfoNodeFlags, but IsHidden doesn't actually care about or use node flags.  It does care about Finder attributes, but it's not getting those.  FSGetCatalogInfo is filling in the wrong portion of the FSCatalogInfo struct (the nodeFlags field), and when IsHidden is looking at the finderInfo field, it's looking at leftover stack garbage.  Since we don't actually care about nodeFlags in IsHidden, I'm removing kFSCatInfoNodeFlags and replacing it with kFSCatInfoFinderInfo.

nsIFile::IsHidden is used by at least netwerk/base, xpfe/components/filepicker, and xpfe/components/search.

Comment 1

[Mark Mentovai]

Attachment: Use kFSCatInfoFinderInfo to obtain Finder attributes

Comment 2

[Mark Mentovai]

Checked in on the trunk.  This is risk-free and ensures that the apps properly treat hidden files as hidden, and more importantly, visible files as visible.

Comment 3

[Mark Mentovai]

*** Bug 314579 has been marked as a duplicate of this bug. ***

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 203843 [details] [diff] [review]
Use kFSCatInfoFinderInfo to obtain Finder attributes

a=dveditz

Comment 5

[Daniel Veditz [:dveditz]]

When this gets checked into the branches please add the appropriate fixed1.8.0.1 and fixed1.8.1 keywords to the bug

Comment 6

[Mark Mentovai]

Checked in to 1_8 and 1_8_0.

Comment 7

[Marcia Knous [:marcia]]

Mark: Is there any easy way for QA to verify this bug?