Closed Bug 317439 Opened 20 years ago Closed 20 years ago

Should be able to remove a download from the download list with delete key

Categories

(Camino Graveyard :: Downloading, enhancement)

Product:
Camino Graveyard
Component:
Downloading
Platform:
PowerPC
macOS
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Camino1.0

People

(Reporter: matthew, Assigned: bugzilla-graveyard)

References

Details

(Keywords: fixed1.8)

Attachments

(1 file, 1 obsolete file)

new version, incorporating Nick's suggestions
1.14 KB, patch
nick.kreeger
: review+
sfraser_bugs
: superreview+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; de-de) AppleWebKit/412.6 (KHTML, like Gecko) Safari/412.2 Build Identifier: Version 2005110708 (1.0b1) See above. Reproducible: Always
*** Bug 317440 has been marked as a duplicate of this bug. ***
Using 1.0b1 I'm perfectly able to do this. WFM?
Apparently this isn't a problem but I have just rechecked and I don't seem to be able to... I am using Mac OS X 10.4.3 on an iMac G5 2Ghz if thats any help...
WFM as well. See if tossing your ~/Library/Preferences/org.mozilla.camino.plist and ~/Library/Preferences/org.mozilla.navigator.plist files helps. (You will need to re-set your preferences after tossing these files.) cl
After deleting those files it works OK with the backspace key but not the delete key, when i press that my iMac beeps at me...
backspace works, delete key doesn't (standard apple extended keyboard). are we not trapping the right key? they are different, we have to look for both.
Status: UNCONFIRMED → NEW
Ever confirmed: true
The same seems to happen before and after resetting Camino (after re-removing the camino file too.)
Taking and targeting for 1.0. If I don't have a patch up within 48 hours, someone holler at me. cl
Assignee: mikepinkerton → bugzilla
Target Milestone: --- → Camino1.0
Status: NEW → ASSIGNED
Tweaking summary, apologies for the bugspam. cl
Summary: Should be able to remove a download from the download list with delete/backspace keys → Should be able to remove a download from the download list with delete key
Attached patch also checks for fwd-delete key (obsolete) — — Splinter Review
Attachment #203979 - Flags: review?(nick.kreeger)
Comment on attachment 203979 [details] [diff] [review] also checks for fwd-delete key This looks fine, but looking down in the next case statement (NSDeleteCharacter:), we could move all that checking code out and use |shouldAllowRemoveAction:| because all that code is used in that method (and it uses a NSEnum.)
Attachment #203979 - Attachment is obsolete: true
Attachment #203989 - Flags: review?(nick.kreeger)
Attachment #203979 - Flags: review?(nick.kreeger)
Comment on attachment 203989 [details] [diff] [review] new version, incorporating Nick's suggestions Looks good to me
Attachment #203989 - Flags: review?(nick.kreeger) → review+
Attachment #203989 - Flags: superreview+
(In reply to comment #8) Holla back. Branch and trunk.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: