317533 - "function does not always return a value" does not handle if-statement well

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P4)

Description

[shutdown]

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20051122 Firefox/1.6a1

JS strict warning "function does not always return a value" does not appear
correctly if the last statement in the function is if-without-else-clause.

javascript: _options.strict=true; eval("function(x){ if(x) return x; }");
=> not warned
javascript: _options.strict=true; eval("function(x){ if(x) return x; ; }");
=> warned

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Stupid patch

If there's no else clause, then we can't assume that we always hit the if clause.

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 204059 [details] [diff] [review]
Stupid patch

r=me, thanks!

/be

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk. I tweaked the patch some to avoid the recursive call if we were going to ignore the result anyway.

Comment 4

[Bob Clary [:bc] (inactive)]

/cvsroot/mozilla/js/tests/js1_5/Regress/regress-317533.js,v  <--  regress-317533.js
initial revision: 1.1

Comment 5

[Bob Clary [:bc] (inactive)]

verified windows/linux/mac trunk

Comment 6

[Bob Clary [:bc] (inactive)]

fixed by Bug 336373 on the 1.8.1 branch. 
verified fixed 1.8.1 with windows/macppc/linux 20060707