Closed Bug 317568 Opened 15 years ago Closed 15 years ago

Stub executable opens console window

Categories

(Toolkit Graveyard :: XULRunner, defect)

1.8 Branch
x86
Windows XP
defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mossop, Assigned: mossop)

Details

(Keywords: fixed1.8.0.1, fixed1.8.1)

Attachments

(1 file, 1 obsolete file)

In windows the XULRunner stub executable appears to have been compiled as a console application and so when running it briefly opens a console window.
Confirming. I see this too and it's annoying.
Anyone care to write a patch? It basically involves writing a stub WinMain and passing /subsystem:windows to the linker (see xulrunner/app/Makefile.in which does basically the same thing).
Yeah why not
Assignee: nobody → mossop
Status: NEW → ASSIGNED
Attached patch Compile stub as a windows app. (obsolete) — Splinter Review
Adds a WinMain and sets up for compiling a windows app unless this is a debug build.

Built and seems working.
Attachment #207841 - Flags: first-review?(benjamin)
Flags: blocking1.8.1?
Comment on attachment 207841 [details] [diff] [review]
Compile stub as a windows app.

Please remove the line DEFINES +=, that is not needed (since you don't use MOZ_WINCONSOLE in the C++).
Attachment #207841 - Flags: first-review?(benjamin) → first-review-
Attached patch 2nd attemptSplinter Review
Next try.
Attachment #207841 - Attachment is obsolete: true
Attachment #207842 - Flags: first-review?(benjamin)
Comment on attachment 207842 [details] [diff] [review]
2nd attempt

Land and verify this on trunk, and I can approve it to make 1.8.0.1
Attachment #207842 - Flags: first-review?(benjamin) → first-review+
mozilla/xulrunner/stub/Makefile.in; new revision: 1.4;
mozilla/xulrunner/stub/nsXULStub.cpp; new revision: 1.4;
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Verified
Status: RESOLVED → VERIFIED
Comment on attachment 207842 [details] [diff] [review]
2nd attempt

a=me for xulrunner-only fix
Attachment #207842 - Flags: approval1.8.1+
Attachment #207842 - Flags: approval1.8.0.1+
Checked in on both branches.
1_8_0:
mozilla/xulrunner/stub/Makefile.in 	1.1.2.2.2.1
mozilla/xulrunner/stub/nsXULStub.cpp 	1.1.2.3.2.2
1_8:
mozilla/xulrunner/stub/nsXULStub.cpp 	1.1.2.5
mozilla/xulrunner/stub/Makefile.in 	1.1.2.3 
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.