317568 - Stub executable opens console window

Status: VERIFIED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Dave Townsend [:mossop]]

In windows the XULRunner stub executable appears to have been compiled as a console application and so when running it briefly opens a console window.

Comment 1

[Chris Cook]

Confirming. I see this too and it's annoying.

Comment 2

[Benjamin Smedberg]

Anyone care to write a patch? It basically involves writing a stub WinMain and passing /subsystem:windows to the linker (see xulrunner/app/Makefile.in which does basically the same thing).

Comment 3

[Dave Townsend [:mossop]]

Yeah why not

Comment 4

[Dave Townsend [:mossop]]

Attachment: Compile stub as a windows app.

Adds a WinMain and sets up for compiling a windows app unless this is a debug build.

Built and seems working.

Comment 5

[Benjamin Smedberg]

Comment on attachment 207841 [details] [diff] [review]
Compile stub as a windows app.

Please remove the line DEFINES +=, that is not needed (since you don't use MOZ_WINCONSOLE in the C++).

Comment 6

[Dave Townsend [:mossop]]

Attachment: 2nd attempt

Next try.

Comment 7

[Benjamin Smedberg]

Comment on attachment 207842 [details] [diff] [review]
2nd attempt

Land and verify this on trunk, and I can approve it to make 1.8.0.1

Comment 8

[:Gavin Sharp [email: [e-mail]]]

mozilla/xulrunner/stub/Makefile.in; new revision: 1.4;
mozilla/xulrunner/stub/nsXULStub.cpp; new revision: 1.4;

Comment 9

[Dave Townsend [:mossop]]

Verified

Comment 10

[Benjamin Smedberg]

Comment on attachment 207842 [details] [diff] [review]
2nd attempt

a=me for xulrunner-only fix

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Checked in on both branches.
1_8_0:
mozilla/xulrunner/stub/Makefile.in 	1.1.2.2.2.1
mozilla/xulrunner/stub/nsXULStub.cpp 	1.1.2.3.2.2
1_8:
mozilla/xulrunner/stub/nsXULStub.cpp 	1.1.2.5
mozilla/xulrunner/stub/Makefile.in 	1.1.2.3