Closed Bug 317568 Opened 17 years ago Closed 17 years ago
Stub executable opens console window
In windows the XULRunner stub executable appears to have been compiled as a console application and so when running it briefly opens a console window.
Confirming. I see this too and it's annoying.
Anyone care to write a patch? It basically involves writing a stub WinMain and passing /subsystem:windows to the linker (see xulrunner/app/Makefile.in which does basically the same thing).
Yeah why not
Assignee: nobody → mossop
Adds a WinMain and sets up for compiling a windows app unless this is a debug build. Built and seems working.
Attachment #207841 - Flags: first-review?(benjamin)
Comment on attachment 207841 [details] [diff] [review] Compile stub as a windows app. Please remove the line DEFINES +=, that is not needed (since you don't use MOZ_WINCONSOLE in the C++).
Attachment #207841 - Flags: first-review?(benjamin) → first-review-
Comment on attachment 207842 [details] [diff] [review] 2nd attempt Land and verify this on trunk, and I can approve it to make 188.8.131.52
Attachment #207842 - Flags: first-review?(benjamin) → first-review+
mozilla/xulrunner/stub/Makefile.in; new revision: 1.4; mozilla/xulrunner/stub/nsXULStub.cpp; new revision: 1.4;
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Comment on attachment 207842 [details] [diff] [review] 2nd attempt a=me for xulrunner-only fix
Checked in on both branches. 1_8_0: mozilla/xulrunner/stub/Makefile.in 184.108.40.206.2.1 mozilla/xulrunner/stub/nsXULStub.cpp 220.127.116.11.2.2 1_8: mozilla/xulrunner/stub/nsXULStub.cpp 18.104.22.168 mozilla/xulrunner/stub/Makefile.in 22.214.171.124
You need to log in before you can comment on or make changes to this bug.