317599 - Fix references to nonexistent _solaris32.cfg and _solaris64.cfg in mozilla/configure.in and mozilla/directory/c-sdk/configure.in

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Wan-Teh Chang]

In NSPR 4.5.1, we merged _solaris32.cfg and _solaris64.cfg
into one file, _solaris.cfg.  So the references to
_solaris32.cfg and _solaris64.cfg in mozilla/configure.in
and mozilla/directory/c-sdk/configure.in need to be updated.

Comment 1

[cls]

Attachment: v1

Comment 2

[Wan-Teh Chang]

Comment on attachment 204470 [details] [diff] [review]
v1

r=wtc.  Some comments:

1. The mozilla/configure.in changes showed that the original
code was wrong for 64-bit Solaris because its TARGET_NSPR_MDCPUCFG
value is changed back to md/_solaris32.cfg later in the file.

2. I don't understand why mozilla/directory/c-sdk/configure.in
needs to know about solaris.c, an internal source file of NSPR.
I guess it's because mozilla/directory/c-sdk/configure.in was
based on mozilla/nsprpub/configure.in.

Comment 3

[Mark Smith [:mcs]]

(In reply to comment #2)
> (From update of attachment 204470 [details] [diff] [review] [edit])
> r=wtc.  Some comments:
> ...
> 2. I don't understand why mozilla/directory/c-sdk/configure.in
> needs to know about solaris.c, an internal source file of NSPR.
> I guess it's because mozilla/directory/c-sdk/configure.in was
> based on mozilla/nsprpub/configure.in.

I am sure that is the case.  Probably all references to solaris.c can be safely removed.
> 

Comment 4

[cls]

1. Yeah.  The 64-bit OS check was moved from its original spot to handle AIX and the solaris bit was overlooked.

2. I opened bug 318149 to deal with the PR_MD_CSRCS removals.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 204470 [details] [diff] [review]
v1

r=dmose

Comment 6

[cls]

/cvsroot/mozilla/directory/c-sdk/configure,v  <--  configure
new revision: 5.32; previous revision: 5.31
done
Checking in directory/c-sdk/configure.in;
/cvsroot/mozilla/directory/c-sdk/configure.in,v  <--  configure.in
new revision: 5.34; previous revision: 5.33
done

Checking in configure;
/cvsroot/mozilla/configure,v  <--  configure
new revision: 1.1549; previous revision: 1.1548
done
Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1559; previous revision: 1.1558
done
Checking in directory/c-sdk/configure;
/cvsroot/mozilla/directory/c-sdk/configure,v  <--  configure
new revision: 5.0.2.35; previous revision: 5.0.2.34
done
Checking in directory/c-sdk/configure.in;
/cvsroot/mozilla/directory/c-sdk/configure.in,v  <--  configure.in
new revision: 5.0.2.36; previous revision: 5.0.2.35