317607 - For minimonth should be used localization language and not OS language

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Michael Wolf]

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; hsb-DE; rv:1.7.6) Gecko/20050319
Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; hsb-DE; rv:1.7.6) Gecko/20050319

I prepared an Upper Sorbian language pack for Sunbird 0.3 Alpha1. The minimonth left is always sgown in German that is the language of my OS. This applies to the orginal English Sunbird, too.
I tested it also with the Polish zip build. The same result.

Reproducible: Always



Expected Results:  
Minimonth language should correspond to the localization language.

Comment 1

[gekacheka]

The minimonth was changed in Bug 260120 to use code like date.toLocaleFormat("%B") to get the month names and weekday names.  The reason for that change was to get date/time picker widgets that could be used in toolkit, for XForms.  For toolkit, they wanted controls that didn't have to be localized and instead relied on the operating system for localization.

The dates displayed in the rest of the application also rely on the operating system, so if the date format is not numerical, you will see non-localized dates everywhere.

How are dates handled in thunderbird/seamonkey in your locale?

Internationalization issue: should mozilla apps be localizable to locales other than the operating system current locale?  Historically they have been, but date formatting is a special case.  

Comment 2

[Michael Wolf]

(In reply to comment #1)
> The dates displayed in the rest of the application also rely on the operating
> system, so if the date format is not numerical, you will see non-localized
> dates everywhere.
I think every application should be completely localizable. Numerical dates should use the correct format common for certain country. Month names and day names and their abbreviations should be in the language of the application. A similar problem are common controls lik Open File, Save File and Print which use the OS language, too. But this is another subject. 
The minimonth of the calendar extension 2005-01-11, afaik the recent version, uses the localized month and day names. I copied the its datepickers folder to Sunbird, repacked the calendar.jar, and it works in Sunbird, too.

> How are dates handled in thunderbird/seamonkey in your locale?
Unfortunately there's the same problem.
 
> Internationalization issue: should mozilla apps be localizable to locales other
> than the operating system current locale?  Historically they have been, but
> date formatting is a special case.  
Yes, of course. Like Upper Sorbian there are a lot of minority languages they don't have a localized OS. But you can localize applications. That localization remains, however, unperfect if there are simply adopted the OS preferences. 

Comment 3

[Matthew (lilmatt) Willis]

Reassigning all automatically assigned bugs from Mostafa to nobody@m.o

Bugspam filter: TorontoMostafaMove

Comment 4

[Matthew (lilmatt) Willis]

*** Bug 353819 has been marked as a duplicate of this bug. ***

Comment 5

[Damian Szczepanik]

Will be lovely if we can spend some time to localize minimonth before next release.

Comment 6

[cmtalbert]

No QA really needed on this, the issue is well-defined.  Here is a suggestion to resolve the issue: Perhaps when there is a difference in language between the OS and the application, the minimonth (and other related components) should use the application language instead of the OS langauge.

Comment 7

[gekacheka]

Attachment: v1 patch minimonth to use UILocale strings for month and day abbrevs, falling back to OS locale

(patch -l -p 1 -i file.patch)

Patches Minimonth to use UILocale localized dateFormat.properties strings if they are available for month and weekday names, else falls back to Date.toLocaleFormat for operating system format.

Patches goToDateDialog to load calendarUtils.js so the date picker there also uses the UILocale strings.

Minimonth previously used UILocale for strings, so most locales already have the necessary strings. 

Expected result:
For each minimonth (date tab; go-to-date dialog; event dialog start date, event dialog end date, todo dialog due date; event dialog repeat-until date)
  In english the month names should be the same full month names.
  The weekday headers should become 1-letter abbreviations, such as
  M T W T F S S  if the week starts on Monday.
  (If I missed datepicker somewhere that shows 2-letter abbreviations,
   that probably means it's in a dialog that needs to load calendarUtils.js)



(Trivia:  minimonth has changed filenames several times so the versions using UILocale strings are not in the history for minimonth.xml [due to limitation of CVS: renaming loses history].  Previous file names include minimonth.xbl and calendar.xbl; before that it was in datepicker/datepicker-overlay.xul
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/calendar/resources/content/datetimepickers/minimonth.xbl
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/calendar/resources/content/datepicker/Attic/datepicker-overlay.xul
)

Comment 8

[gekacheka]

Attachment: v1 patch en-US weekdays abbrevs: S M T W T F S -> Su M Tu W Th F Sa

(patch -l -p 1 -i file.patch)

Once previous patch is checked to verify no missed datepickers, this patch makes en-US locale appear as before, so overall there should be no UI change, at least for en-US.

Comment 9

[cmtalbert]

Comment on attachment 253099 [details] [diff] [review]
v1 patch minimonth to use UILocale strings for month and day abbrevs, falling back to OS locale

Sorry it took me so long to get to this...

>@@ -219,7 +225,14 @@
>             var i, j;
>             tempDate.setDate(tempDate.getDate() - (tempDate.getDay() - this.weekStart));
>             for (i = 0; i < header.childNodes.length; i++) {
>-              dayList[i] = tempDate.toLocaleFormat("%a")
>+              // if available, use UILocale days, else operating system format
>+              try { 
Extra space after this {

>+              } catch (e) { 
Extra space after this {

Besides those two nits, this looks good. Tested on windows.

Comment 10

[cmtalbert]

Comment on attachment 253101 [details] [diff] [review]
v1 patch en-US weekdays abbrevs: S M T W T F S -> Su M Tu W Th F Sa

Looks good

Comment 12

[gekacheka]

Attachment: v2 patch minimonth to use UILocale strings for month and day abbrevs, falling back to OS locale

(patch -l -p 1 -i file.patch)

Nit addressed.  Description in comment #7.

Comment 13

[gekacheka]

Comment on attachment 253101 [details] [diff] [review]
v1 patch en-US weekdays abbrevs: S M T W T F S -> Su M Tu W Th F Sa

2r?: Please find description of attachment 253101 [details] [diff] [review] in comment #8.

Comment 14

[Joey Minta]

Comment on attachment 254642 [details] [diff] [review]
v2 patch minimonth to use UILocale strings for month and day abbrevs, falling back to OS locale

+                calGetString("dateFormat", "month."+ (month+1)+ ".name");

Operators like + should have spaces on both sides of them.

r2=jminta with that.

Comment 15

[gekacheka]

Attachment: v3 patch minimonth to use UILocale strings for month and day abbrevs, falling back to OS locale (nits addressed)

(patch -l -p 1 -i file.patch)

Nit addressed.

Comment 16

[Joey Minta]

Patch checked in.
  calendar/resources/content/goToDateDialog.xul: 1.4 -> 1.5.
  calendar/resources/content/datetimepickers/minimonth.xml: 1.12 -> 1.13

Comment 17

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2pre) Gecko/20070214 Calendar/0.4a1

Comment 18

[Martin Schröder [:mschroeder]]

Comment on attachment 253101 [details] [diff] [review]
v1 patch en-US weekdays abbrevs: S M T W T F S -> Su M Tu W Th F Sa

I think, this patch wasn't checked in before marking this bug fixed.

Comment 19

[gekacheka]

(In reply to comment #18)
> (From update of attachment 253101 [details] [diff] [review])
> I think, this patch wasn't checked in before marking this bug fixed.
> 
reopened awaiting check in

Comment 20

[Matthew (lilmatt) Willis]

(In reply to comment #19)
> > (From update of attachment 253101 [details] [diff] [review] [details])

Checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

Comment 21

[Stefan Sitter [:ssitter]]

Verified using Thunderbird 2.0pre (20070227) + Lightning 0.5pre (2007022803) and en-US/de/ru Sunbird 0.5pre (20070228)