317612 - Read only Nodes

Status: RESOLVED INVALID

(Firefox :: Bookmarks & History, defect, P2)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

Some nodes in the Places list we do not want to delete, e.g. the Bookmarks Toolbar and Menu item, and the views that let you access history. There should be a way for specifying that a node cannot be removed.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

If bookmark folders could be expressed as place: uris, then this information could be stored with the annotation service.

Comment 2

[Brett Wilson]

The problem with a readonly "place:" annotation is that its easy for the user to create the same query somewhere in their hierarchy. For example, all history today is a pretty simple query. If they happened to get the same parameters, their query would instantly become readonly.

We could add something to place URLs that would differentiate them from user-defined queries. This would cover the history items which are fancy queries. For folders, we can have some special format as well that would ensure it is different from a query that references that folder.

Comment 3

[Brian Ryner (not reading)]

It seems like we should actually have a separate "readonly" property on the Query object, which is encoded in the place: url as readonly=1.  This would serve as a hint to the UI.  The UI would probably not provide any means for making a node read-only.

Comment 4

[Brian Ryner (not reading)]

Ben and I decided this is more easily just implemented in the places view, as the items we want to lock down only appear in that view.

I will file a separate bug to implement "the children of this container can't be added to / removed / reordred"

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

there should be a readonly property on queries that say that this is a system query. this should be reflected into the place: URI so that in our default_places.html file we can have:

place:param=value&param=value&system=true 

or something

then we can set annotations based on that. 

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv