317694 - All buttons in forms must have an id

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Frédéric Buclin]

This is required to use Selenium correctly (automated QA tests).

At least one button in search/form.html.tmpl has no name nor id, but I suppose most of the buttons have none too.

I need it for 2.20!

Comment 1

[Frédéric Buclin]

Every time we see type="submit", we should also find either id="foo" and/or name="foo":

90:  <input type="submit" name="GoAheadAndLogIn" value="Log in">
126:      <input type="submit" value="Submit Request">
504448    4 -rw-r-----   1 root     apache       3726 avr 12  2005 ./account/auth/login.html.tmpl
64:      <td><input type="submit" name="GoAheadAndLogIn" value="Login"></td>
504449    4 -rw-r-----   1 root     apache       2352 avr 12  2005 ./account/auth/login-small.html.tmpl
72:  <input type="submit" value="Create Account">
504451    4 -rw-r-----   1 root     apache       2215 jan 18  2004 ./account/create.html.tmpl
37:  <input type="submit" value="submit a request to change it">.
504453    4 -rw-r-----   1 root     apache       1466 jan 18  2004 ./account/exists.html.tmpl
43:      <td><input type="submit" value="Submit"></td>
504459    4 -rw-r-----   1 root     apache       1554 mar 18  2004 ./account/email/confirm.html.tmpl
50:        <input type="submit" value="Submit">
504466    4 -rw-r-----   1 root     apache       1672 jan 18  2004 ./account/password/set-forgotten-password.html.tmpl
99:            <input type="submit" value="Submit Changes">
504506    4 -rw-r-----   1 root     apache       3919 oct 28 11:54 ./account/prefs/prefs.html.tmpl
95:    <input id="find" type="submit" value="Find">
504488    4 -rw-r-----   1 root     apache       3637 aoû 21 19:56 ./index.html.tmpl
149:  <input type="submit" value="Yes, delete">
504580    8 -rw-r-----   1 root     apache       4488 sep  7 01:49 ./admin/components/confirm-delete.html.tmpl
76:  <input type="submit" value="Add">
504515    4 -rw-r-----   1 root     apache       2709 jun 20 21:08 ./admin/components/create.html.tmpl
97:   <input type="submit" value="Update"> or <a
504584    4 -rw-r-----   1 root     apache       3518 sep  7 01:49 ./admin/components/edit.html.tmpl
118:              <input type="submit" name="categoryAction-include" value="Include">
119:              <input type="submit" name="categoryAction-exclude" value="Exclude">
124:              <input type="submit" name="categoryAction-removeInclusion" value="Remove Inclusion">
129:              <input type="submit" name="categoryAction-removeExclusion" value="Remove Exclusion">
216:        <input type="submit" value="
504527   12 -rw-r-----   1 root     apache       9135 aoû 30 18:44 ./admin/flag-type/edit.html.tmpl
91:      <input name="confirm" type="submit" value="Confirm">
504536    4 -rw-r-----   1 root     apache       3565 jui 13  2004 ./admin/groups/change.html.tmpl
50:  <input type="submit" value="Add">
504537    4 -rw-r-----   1 root     apache       3503 jui 13  2004 ./admin/groups/create.html.tmpl
103:  <p><input type="submit" value="Yes, delete">
504539    8 -rw-r-----   1 root     apache       4113 aoû  1 01:45 ./admin/groups/delete.html.tmpl
173:  <input type="submit" value="Save Changes">
202:            <input name="remove_explicit_members" type="submit" id="remove_explicit_members" value="Remove Memberships">
207:            <input name="remove_explicit_members_regexp" type="submit" id="remove_explicit_members_regexp" value="Remove memberships included in regular expression">
504541    8 -rw-r-----   1 root     apache       7584 fév 18  2005 ./admin/groups/edit.html.tmpl
49:  <input type="submit" value="Yes, really delete the keyword">
504549    4 -rw-r-----   1 root     apache       1821 jan 18  2004 ./admin/keywords/confirm-delete.html.tmpl
48:  <input type="submit" value="Add">
504550    4 -rw-r-----   1 root     apache       1715 jan 18  2004 ./admin/keywords/create.html.tmpl
62:  <input type="submit" value="Update">
504552    4 -rw-r-----   1 root     apache       2241 jui 11 01:37 ./admin/keywords/edit.html.tmpl
90:  <input type="submit" value="Yes, delete">
504558    4 -rw-r-----   1 root     apache       2922 jui 28 02:29 ./admin/milestones/confirm-delete.html.tmpl
48:  <input type="submit" value="Add">
504559    4 -rw-r-----   1 root     apache       2085 aoû 23 14:35 ./admin/milestones/create.html.tmpl
58:  <input type="submit" value="Update">
504564    4 -rw-r-----   1 root     apache       2221 aoû 23 14:35 ./admin/milestones/edit.html.tmpl
51:    <input type="submit" value="Continue">
505278    4 -rw-r-----   1 root     apache       1917 oct 17 23:41 ./admin/products/groupcontrol/confirm-edit.html.tmpl
263:    <input type="submit" value="Yes, delete">
507422    8 -rw-r-----   1 root     apache       7234 nov 19 02:11 ./admin/products/confirm-delete.html.tmpl
56:  <input type="submit" value="Add">
507441    4 -rw-r-----   1 root     apache       2150 oct 26 19:01 ./admin/products/create.html.tmpl
137:  <input type="submit" name="submit" value="Update">
507464    8 -rw-r-----   1 root     apache       4635 oct 26 19:01 ./admin/products/edit.html.tmpl
92:    <input type="submit" value="Yes, delete">
504589    4 -rw-r-----   1 root     apache       2857 mai 22  2005 ./admin/versions/confirm-delete.html.tmpl
42:  <input type="submit" value="Add">
504590    4 -rw-r-----   1 root     apache       1817 jan 16  2005 ./admin/versions/create.html.tmpl
50:  <input type="submit" value="Update">
504595    4 -rw-r-----   1 root     apache       1891 jan 16  2005 ./admin/versions/edit.html.tmpl
110:    <input type="submit" value="Yes, delete">
507484    4 -rw-r-----   1 root     apache       4078 oct 20 00:16 ./admin/fieldvalues/confirm-delete.html.tmpl
42:  <input type="submit" value="Add">
504604    4 -rw-r-----   1 root     apache       1765 jun 15 18:17 ./admin/fieldvalues/create.html.tmpl
51:  <input type="submit" value="Update">
504609    4 -rw-r-----   1 root     apache       1997 sep  1 23:58 ./admin/fieldvalues/edit.html.tmpl
415:      <input type="submit" value="Yes, delete" />
507503   16 -rw-r-----   1 root     apache      15158 oct 17 23:08 ./admin/users/confirm-delete.html.tmpl
42:  <input type="submit" value="Add" />
504620    4 -rw-r-----   1 root     apache       1670 fév 28  2005 ./admin/users/create.html.tmpl
104:  <input type="submit" value="Update" />
127:    <input type="submit" value="Delete User" />
504647    8 -rw-r-----   1 root     apache       5314 sep  4 20:41 ./admin/users/edit.html.tmpl
46:<input type="submit" value="Search" /></p>
507378    4 -rw-r-----   1 root     apache       2482 sep  4 20:41 ./admin/users/search.html.tmpl
92:          <input type="submit" value="Submit Changes">
507383    4 -rw-r-----   1 root     apache       3365 jun 20 23:11 ./admin/settings/edit.html.tmpl
95:    <input type="submit" value="Begin Session">
507508    4 -rw-r-----   1 root     apache       3323 nov 20 19:28 ./admin/sudo.html.tmpl
103:          <input type="submit" name="action" value="Save Changes">
520238    4 -rw-r-----   1 root     apache       3741 oct 13 11:15 ./admin/params/editparams.html.tmpl
40:  <input type="submit" name="action" value="View">
507388    4 -rw-r-----   1 root     apache       1633 aoû 23  2004 ./attachment/choose.html.tmpl
245:      <td><input type="submit" value="Submit"></td>
507515   12 -rw-r-----   1 root     apache       9314 oct 19 22:29 ./attachment/create.html.tmpl
260:      <input type="submit" value="Diff">
507520   12 -rw-r-----   1 root     apache       9576 oct 17 23:54 ./attachment/diff-header.html.tmpl
244:        <input type="submit" value="Submit"><br><br>
507533   12 -rw-r-----   1 root     apache      11523 oct 20 10:04 ./attachment/edit.html.tmpl
32:    <input type="submit" value="Show Me This [% terms.Bug %]">
507411    4 -rw-r-----   1 root     apache       1257 jan 18  2004 ./bug/choose.html.tmpl
107:  <input type="submit" value="Change Parameters">
507413    4 -rw-r-----   1 root     apache       3224 oct 12 03:00 ./bug/dependency-graph.html.tmpl
167:     <input type="submit"
184:     <input type="submit" value="&nbsp;1&nbsp;"
203:     <input type="submit" value="&nbsp;&lt;&nbsp;"
219:       <input type="submit" value="Change" [% "disabled" IF realdepth < 2 %]>
234:     <input type="submit" value="&nbsp;&gt;&nbsp;"
246:     <input type="submit" value="&nbsp;Unlimited&nbsp;"
507414   12 -rw-r-----   1 root     apache       8629 oct 28 12:11 ./bug/dependency-tree.html.tmpl
164:  <input type="submit" value="Commit">
184:      <input type="submit" name="action"
507418    8 -rw-r-----   1 root     apache       7059 sep  7 13:48 ./bug/knob.html.tmpl
160:    <input type="submit" value="Search">
487:  <input type="submit" value="    Submit [% terms.Bug %] Report    "
507431   20 -rw-r-----   1 root     apache      17673 jun  9 14:04 ./bug/create/create-guided.html.tmpl
402:      <input type="submit" value="    Commit    "
407:      <input type="submit" name="maketemplate"
507432   16 -rw-r-----   1 root     apache      13006 nov  4 11:15 ./bug/create/create.html.tmpl
71:  <input type="submit" value="Submit">
507442    4 -rw-r-----   1 root     apache       2541 avr  8  2005 ./bug/process/confirm-duplicate.html.tmpl
78:      <input type="submit" value="Submit my changes anyway">
507446    4 -rw-r-----   1 root     apache       2907 nov  5 13:35 ./bug/process/midair.html.tmpl
104:<input type="submit" value="Commit">
507448    4 -rw-r-----   1 root     apache       3910 jui 13 00:23 ./bug/process/verify-new-product.html.tmpl
48:    <input type="submit" value="Submit">
507452    4 -rw-r-----   1 root     apache       1615 jan 18  2004 ./bug/votes/delete-all.html.tmpl
150:      <input type="submit" value="Change My Votes">
507454    8 -rw-r-----   1 root     apache       5553 fév 15  2005 ./bug/votes/list-for-user.html.tmpl
271:  <input type="submit" value="Summarize">
507580   12 -rw-r-----   1 root     apache      10135 oct 17 23:54 ./bug/summarize-time.html.tmpl
151:    <input type="submit" value="Continue">
507469    8 -rw-r-----   1 root     apache       5789 jui  8 00:33 ./global/confirm-user-match.html.tmpl
41:            <input class="btn" type="submit" value="Find">
507594    8 -rw-r-----   1 root     apache       5703 oct 25 19:49 ./global/useful-links.html.tmpl
25:        <input type="submit" value="Add"> [% terms.bugs %]
507596    4 -rw-r-----   1 root     apache       1706 nov 17 11:56 ./global/per-bug-queries.html.tmpl
67:    <input type="submit" value="Change Columns">
74:  <input type="submit" value="Reset to [% terms.Bugzilla %] default">
507497    4 -rw-r-----   1 root     apache       2651 jan 18  2004 ./list/change-columns.html.tmpl
347:<input type="submit" value="Commit">
350:  <input type="submit" name="action" value="[% Param('move-button-text') %]">
507597   12 -rw-r-----   1 root     apache      11321 oct 12 04:01 ./list/edit-multiple.html.tmpl
146:          <input type="submit" value="&nbsp;&nbsp;Long Format&nbsp;">
154:            <input type="submit" value="XML">
160:            <input type="submit" value="Time Summary">
216:          <input type="submit" value="Remember search"> as
507602   12 -rw-r-----   1 root     apache       8567 nov 19 02:27 ./list/list.html.tmpl
79:      <input type="submit" value="Add This Quip">
151:      <input type="submit" value="Update">
507507    8 -rw-r-----   1 root     apache       5294 jun 20 21:34 ./list/quips.html.tmpl
36:  <input value="Linkify" type="submit">
507517    4 -rw-r-----   1 root     apache       1497 fév  9  2005 ./pages/linkify.html.tmpl
43:  <input type="submit" value="Find">
507519    8 -rw-r-----   1 root     apache       5722 aoû 21 19:56 ./pages/quicksearch.html.tmpl
35:  <input type="submit" value="Find">
36:  <input type="submit" name="load" value="Load Search Form">
507589   12 -rw-r-----   1 root     apache       9327 aoû 28 17:24 ./pages/quicksearchhack.html.tmpl
90:            <input type="submit" name="action-assemble" value="Update --&gt;">
100:            <input type="submit" name="action-assemble" value="Update --&gt;">
121:          <input type="submit" name="action-add" value="Add To List"><br>
229:          <input type="submit" name="action-sum" value="Sum"
231:          <input type="submit" name="action-remove" value="Remove"
252:          <input type="submit" name="action-wrap" value="Chart This List">
507530   12 -rw-r-----   1 root     apache       8640 fév 25  2005 ./reports/create-chart.html.tmpl
123:  <input type="submit" value="Change">
129:  Or just give this to me as a <input type="submit" value="[% terms.bug %] list">.
507590    8 -rw-r-----   1 root     apache       5708 sep  2 23:05 ./reports/duplicates.html.tmpl
50:            <input type="submit" name="action-edit" value="Update --&gt;">
92:        <input type="submit" name="submit-button"
507548    4 -rw-r-----   1 root     apache       3537 sep 15  2004 ./reports/series.html.tmpl
114:      <td><input type="submit" value="Filter"></td>
507591    8 -rw-r-----   1 root     apache       6525 sep  2 23:05 ./request/queue.html.tmpl
103:          <input type="submit" value="Or"
119:        <input type="submit" value="And"
122:        <input type="submit" value="Add another boolean chart"
507560    8 -rw-r-----   1 root     apache       4877 déc 11  2004 ./search/boolean-charts.html.tmpl
146:        <input type="submit" value="[% button_name FILTER html %]">
507605   20 -rw-r-----   1 root     apache      18895 oct 19 22:29 ./search/form.html.tmpl
57:  <input type="submit" value="[% button_name FILTER html %]">
507562    4 -rw-r-----   1 root     apache       2456 jui 22  2004 ./search/knob.html.tmpl
46:  <input type="submit" name="action-search" value="Run Search">
507564    4 -rw-r-----   1 root     apache       2013 avr 12  2005 ./search/search-create-series.html.tmpl
132:<input type="submit" value="[% button_name FILTER html %]">
507566    8 -rw-r-----   1 root     apache       4354 aoû 20  2004 ./search/search-report-graph.html.tmpl
84:<input type="submit" value="[% button_name FILTER html %]">
507568    4 -rw-r-----   1 root     apache       2494 aoû 20  2004 ./search/search-report-table.html.tmpl
113:      <input type="submit" value="Search">
507606    4 -rw-r-----   1 root     apache       3851 nov  1 00:01 ./search/search-specific.html.tmpl
82:<input type="submit" value="Update / Commit" name="commit"
95:      <input type="submit" value="Remove Event"
130:        <input type="submit" value="Add a new schedule"
187:                <input type="submit" value="Remove"
195:            <input type="submit" value="Add a new schedule"
216:        <input type="submit" value="Add a new query" name="add_query_[% event.key %]">
219:        <input type="submit" value="Update / Commit" name="commit">
268:                <input type="submit" value="Remove"
277:              <input type="submit" value="Add a new query"
286:        <input type="submit" value="Update / Commit" name="commit">
297:  <input type="submit" value="Add a new event" name="add_event">
507577   16 -rw-r-----   1 root     apache      14325 sep 12 15:58 ./whine/schedule.html.tmpl

Comment 2

[André Batosti]

Attachment: batosti_v1

this patch is for BUGZILLA-2_20-BRANCH it's correct?

Comment 3

[Frédéric Buclin]

Comment on attachment 204172 [details] [diff] [review]
batosti_v1

>+      <td align="left"><input type="submit" value="Search" name="run"></td>

For consistency, I would much prefer having the name defined before the value:
<input type="foo" name="bar" value="baz">

Comment 4

[André Batosti]

Attachment: batosti_v1_fix

Comment 5

[Frédéric Buclin]

By looking at the patch, I think it's too risky for 2.20 and even for 2.22 (in the case we would have two fields with the same name). I found a way to bypass the id and name of buttons for Selenium, so this patch is no longer required on branches, but would still be a good thing to have on the trunk.

Comment 6

[Frédéric Buclin]

Err... a button must have an ID, not a name, else its value would appear in $cgi->param(), unless that's what we want (e.g when the template has several buttons).

Comment 7

[Frédéric Buclin]

Comment on attachment 204369 [details] [diff] [review]
batosti_v1_fix

quicksearch.html no longer exists in 2.24. And several other templates have changed meanwhile and your patch doesn't apply cleanly anymore. As this is a huge work, I would prefer to see 10 smaller patches in this bug than only one big patch. This would avoid to bitrot too quickly and this would make my reviews faster.

For instance, we could imagine one patch per directory (admin/products, admin/params, /search, etc...). As I said, I see no problem posting all patches in the same bug.

Comment 8

[André Batosti]

Attachment: batosti_v2

Comment 9

[Frédéric Buclin]

Comment on attachment 215011 [details] [diff] [review]
batosti_v2

>Index: quicksearch.html

As I said, quicksearch.html no longer exists. Please upgrade to 2.23.1 to write this patch. Moreover, as I suggested already, split this patch in several smaller pieces. Else you will bitrot all the time, which is the case here, and this also makes the review *much* harder (actually, I won't review such a big thing). One patch per directory seems more reasonable, for you and for me. ;)

Comment 10

[André Batosti]

Attachment: batosti_v3_account

Comment 11

[André Batosti]

Attachment: batosti_v3_admin_components

Comment 12

[André Batosti]

Attachment: batosti_v3_admin_fieldvalues

Comment 13

[André Batosti]

Attachment: batosti_v3_admin_flag-types

Comment 14

[André Batosti]

Attachment: batosti_v3_admin_groups

Comment 15

[André Batosti]

Attachment: batosti_v3_search

Comment 16

[André Batosti]

Attachment: batosti_v3_whine

Comment 17

[André Batosti]

Attachment: batosti_v3_list

Comment 18

[André Batosti]

Attachment: batosti_v3_bug

Comment 19

[André Batosti]

Attachment: batosti_v3_admin

Comment 20

[André Batosti]

Attachment: batosti_v3_attachment

Comment 21

[André Batosti]

Attachment: batosti_v3_global

Comment 22

[André Batosti]

Attachment: batosti_v3_pages_request_reports

Comment 23

[Frédéric Buclin]

GavinS, could you help me reviewing all these patches? Making sure that IDs and names aren't used twice in the same form is a pain and requires a lot of time.

Comment 24

[GavinS]

(In reply to comment #23)
> GavinS, could you help me reviewing all these patches? Making sure that IDs and
> names aren't used twice in the same form is a pain and requires a lot of time.
> 
WIll do.

Comment 25

[GavinS]

Comment on attachment 219666 [details] [diff] [review]
batosti_v3_global

1) does not apply to tip cleanly

Apart from that, the patch is fine. (But a patch for the tip would have to fix the new per-bug-queries.html.tmpl file as well)

Comment 26

[GavinS]

(In reply to comment #1)
> Every time we see type="submit", we should also find either id="foo" and/or
> name="foo":

What about <button> tags?

Comment 27

[GavinS]

Comment on attachment 219664 [details] [diff] [review]
batosti_v3_attachment

Does not apply cleanly to tip.

Misses out the new-to-tip confirm-delete.html.tmpl

Otherwise fine.

Comment 28

[Frédéric Buclin]

Comment on attachment 219592 [details] [diff] [review]
batosti_v3_account

>Index: auth/login.html.tmpl

You forgot to add an id to <input type="submit" name="GoAheadAndLogIn" value="Log in"> at line 90. Same remark about a similar button at line 77 of ./auth/login-small.html.tmpl.


>Index: password/set-forgotten-password.html.tmpl

>-        <input type="submit" value="Submit">
>+        <input type="submit" name="update" value="Submit">

id= , not name= .

Comment 29

[Frédéric Buclin]

Comment on attachment 219600 [details] [diff] [review]
batosti_v3_search

>Index: boolean-charts.html.tmpl
>-          <input type="submit" value="Or" 
>-                 name="cmd-add[% "${chartnum}-${rownum}-${newor}" %]" [% jsmagic %]>
>+          <input type="submit" id="cmd-add[% "${chartnum}-${rownum}-${newor}" %]"
>+                 value="Or" [% jsmagic %]>

If a name is already defined, do not remove it but only add an id. These names are required by query.cgi.


>-        <input type="submit" value="And" 
>-               name="cmd-add[% "${chartnum}-${newand}-0" %]" [% jsmagic %]> 
>+        <input type="submit" id="cmd-add[% "${chartnum}-${newand}-0" %]"
>+               value="And" [% jsmagic %]> 

Same remark here.


>-        <input type="submit" value="Add another boolean chart" 
>-               name="cmd-add[% newchart %]-0-0" [% jsmagic %]>
>+        <input type="submit" id="cmd-add[% newchart %]-0-0"
>+               value="Add another boolean chart" [% jsmagic %]>

And here.


Moreover, you forgot to add an id to <input type="submit" name="action-search" value="Run Search"> in ./search-create-series.html.tmpl at line 46.

Comment 30

[Frédéric Buclin]

Comment on attachment 219601 [details] [diff] [review]
batosti_v3_whine

>Index: schedule.html.tmpl

>-<input type="submit" value="Update / Commit" name="commit"
>+<input type="submit" id="commit" value="Update / Commit"

You have two buttons with id="commit". You can have several fields with the same name (in which case you get a list), but you cannot have two fields with the same id. ids must be unique. All other buttons are fine, because they are in an [% IF %] [% ELSE %] [% END %] so that you never meet twice the same id.

Moreover, and this comment applies to all buttons, you must *add* an id, not remove existing field names. These names are required by editwhines.cgi.

Comment 31

[Frédéric Buclin]

Comment on attachment 219602 [details] [diff] [review]
batosti_v3_list

>Index: edit-multiple.html.tmpl
>-  <input type="submit" name="action" value="[% Param('move-button-text') %]">
>+  <input type="submit" id="action" value="[% Param('move-button-text') %]">

The name is required by process_bug.cgi. Do not touch field names!



>Index: list.html.tmpl

There is some bitrot here. Moreover, you forgot <input type="submit" value="XML"> at line 154.

Comment 32

[Frédéric Buclin]

Comment on attachment 219668 [details] [diff] [review]
batosti_v3_pages_request_reports

Looks good, except that you missed many files, such as:
./quicksearch.html.tmpl and ./quicksearchhack.html.tmpl in pages/, as well as  ./create-chart.html.tmpl and ./series.html.tmpl in reports/.

Comment 33

[Frédéric Buclin]

Comment on attachment 219603 [details] [diff] [review]
batosti_v3_bug

>Index: knob.html.tmpl

>-      <input type="submit" name="action"
>-             value="[% Param("move-button-text") %]">
>+      <input type="submit" id="action" value="[% Param("move-button-text") %]">

Do not remove field names. This one is required by process_bug.cgi.



>Index: create/create.html.tmpl

You missed <input type="submit" name="maketemplate" at line 464.


Also, the new template ./create/confirm-create-dupe.html.tmpl has no id at line 51: <input type="submit" value="File [% terms.bug %] again">.



>Index: votes/list-for-user.html.tmpl

>-      <input type="submit" value="Change My Votes">
>+      <input type="submit" id="Change My Votes" id="change">

value= has been removed and you have two id=.

Comment 34

[Frédéric Buclin]

Comment on attachment 219663 [details] [diff] [review]
batosti_v3_admin

>Index: flag-type/edit.html.tmpl

>-        <input type="submit" value="
>+        <input type="submit" id=="save" value="

Typo: id=, not id==.

The patch is slightly bitrotten. Else it looks good.

Comment 35

[André Batosti]

Attachment: batosti_v3_admin_fix

Comment 36

[André Batosti]

Attachment: batosti_v3_bug_fix

Comment 37

[André Batosti]

Attachment: batosti_v3_pages_request_reports_fix

Comment 38

[André Batosti]

Attachment: batosti_v3_list_fix

Comment 39

[Greg Hendricks]

Comment on attachment 228186 [details] [diff] [review]
batosti_v3_admin_fix

>Index: components/confirm-delete.html.tmpl
>-  <input type="submit" value="Yes, delete">
>+  <input type="submit" id="delete" value="Yes, delete">

>-        <input type="submit" value="Yes, delete">
>+        <input type="submit" id="delete" value="Yes, delete">

 
>Index: groups/delete.html.tmpl
>===================================================================
>-  <p><input type="submit" value="Yes, delete">
>+  <p><input type="submit" id="delete" value="Yes, delete">

>Index: milestones/confirm-delete.html.tmpl
>-  <input type="submit" value="Yes, delete">
>+  <input type="submit" id="delete" value="Yes, delete">

Why do you use "delete" in all these ...

>===================================================================
>RCS file: /usr/local/cvs/mirrors/cvs.mozilla.org/bugzilla/template/en/default/admin/users/confirm-delete.html.tmpl,v
>retrieving revision 1.4.2.4
>diff -u -p -r1.4.2.4 confirm-delete.html.tmpl
>--- users/confirm-delete.html.tmpl	29 May 2006 18:30:02 -0000	1.4.2.4
>+++ users/confirm-delete.html.tmpl	5 Jul 2006 21:22:23 -0000
>@@ -424,7 +424,7 @@
> 
>   <form method="post" action="editusers.cgi">
>     <p>
>-      <input type="submit" value="Yes, delete" />
>+      <input type="submit" id="confirm" value="Yes, delete"/>
>       <input type="hidden" name="action" value="delete" />

But "confirm" here?

Otherwise this looks good

Comment 40

[André Batosti]

Attachment: batosti_v3_whine_fix

Comment 41

[André Batosti]

Attachment: batosti_v3_search_fix

Comment 42

[André Batosti]

Attachment: batosti_v3_account_fix

Comment 43

[André Batosti]

Attachment: batosti_v3_global_fix

Comment 44

[André Batosti]

Attachment: batosti_v3_attachment_fix

Comment 45

[Greg Hendricks]

Comment on attachment 228186 [details] [diff] [review]
batosti_v3_admin_fix

See comments above

Comment 46

[André Batosti]

Attachment: batosti_v3_admin_fix_fix

Comment 47

[Frédéric Buclin]

Checking in template/en/default/account/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.9; previous revision: 1.8
done
Checking in template/en/default/account/exists.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/exists.html.tmpl,v  <--  exists.html.tmpl
new revision: 1.8; previous revision: 1.7
done
Checking in template/en/default/account/auth/login-small.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/auth/login-small.html.tmpl,v  <--  login-small.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/account/auth/login.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/auth/login.html.tmpl,v  <--  login.html.tmpl
new revision: 1.16; previous revision: 1.15
done
Checking in template/en/default/account/email/confirm.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/email/confirm.html.tmpl,v  <--  confirm.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/account/password/set-forgotten-password.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/password/set-forgotten-password.html.tmpl,v  <--  set-forgotten-password.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/account/prefs/prefs.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/prefs.html.tmpl,v  <--  prefs.html.tmpl
new revision: 1.23; previous revision: 1.22
done
Checking in template/en/default/admin/components/confirm-delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/components/confirm-delete.html.tmpl,v  <--  confirm-delete.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/admin/components/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/components/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/admin/components/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/components/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.8; previous revision: 1.7
done
Checking in template/en/default/admin/fieldvalues/confirm-delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/confirm-delete.html.tmpl,v  <--  confirm-delete.html.tmpl
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/admin/fieldvalues/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/admin/fieldvalues/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/admin/flag-type/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.18; previous revision: 1.17
done
Checking in template/en/default/admin/groups/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/groups/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/admin/groups/delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/groups/delete.html.tmpl,v  <--  delete.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/admin/groups/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/groups/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/admin/keywords/confirm-delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/keywords/confirm-delete.html.tmpl,v  <--  confirm-delete.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/admin/keywords/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/keywords/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/admin/keywords/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/keywords/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/admin/milestones/confirm-delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/milestones/confirm-delete.html.tmpl,v  <--  confirm-delete.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/admin/milestones/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/milestones/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/admin/milestones/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/milestones/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/admin/products/confirm-delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/products/confirm-delete.html.tmpl,v  <--  confirm-delete.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/admin/products/groupcontrol/confirm-edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/products/groupcontrol/confirm-edit.html.tmpl,v  <--  confirm-edit.html.tmpl
new revision: 1.8; previous revision: 1.7
done
Checking in template/en/default/admin/settings/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/settings/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/admin/users/confirm-delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/confirm-delete.html.tmpl,v  <--  confirm-delete.html.tmpl
new revision: 1.9; previous revision: 1.8
done
Checking in template/en/default/admin/users/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/admin/users/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/admin/users/search.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/search.html.tmpl,v  <--  search.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/admin/versions/confirm-delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/versions/confirm-delete.html.tmpl,v  <--  confirm-delete.html.tmpl
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/admin/versions/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/versions/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/admin/versions/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/versions/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/attachment/choose.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/choose.html.tmpl,v  <--  choose.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/attachment/confirm-delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/confirm-delete.html.tmpl,v  <--  confirm-delete.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/attachment/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.28; previous revision: 1.27
done
Checking in template/en/default/attachment/diff-header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/diff-header.html.tmpl,v  <--  diff-header.html.tmpl
new revision: 1.14; previous revision: 1.13
done
Checking in template/en/default/attachment/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.36; previous revision: 1.35
done
Checking in template/en/default/bug/choose.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/choose.html.tmpl,v  <--  choose.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/bug/dependency-graph.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/dependency-graph.html.tmpl,v  <--  dependency-graph.html.tmpl
new revision: 1.11; previous revision: 1.10
done
Checking in template/en/default/bug/dependency-tree.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/dependency-tree.html.tmpl,v  <--  dependency-tree.html.tmpl
new revision: 1.23; previous revision: 1.22
done
Checking in template/en/default/bug/knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/knob.html.tmpl,v  <--  knob.html.tmpl
new revision: 1.21; previous revision: 1.20
done
Checking in template/en/default/bug/summarize-time.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/summarize-time.html.tmpl,v  <--  summarize-time.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/bug/create/confirm-create-dupe.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/confirm-create-dupe.html.tmpl,v  <--  confirm-create-dupe.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/bug/create/create-guided.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create-guided.html.tmpl,v  <--  create-guided.html.tmpl
new revision: 1.32; previous revision: 1.31
done
Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.61; previous revision: 1.60
done
Checking in template/en/default/bug/process/confirm-duplicate.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/confirm-duplicate.html.tmpl,v  <--  confirm-duplicate.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/bug/process/midair.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/midair.html.tmpl,v  <--  midair.html.tmpl
new revision: 1.18; previous revision: 1.17
done
Checking in template/en/default/bug/process/verify-new-product.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/verify-new-product.html.tmpl,v  <--  verify-new-product.html.tmpl
new revision: 1.17; previous revision: 1.16
done
Checking in template/en/default/bug/votes/delete-all.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/votes/delete-all.html.tmpl,v  <--  delete-all.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/bug/votes/list-for-user.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/votes/list-for-user.html.tmpl,v  <--  list-for-user.html.tmpl
new revision: 1.22; previous revision: 1.21
done
Checking in template/en/default/global/common-links.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/common-links.html.tmpl,v  <--  common-links.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/global/confirm-user-match.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/confirm-user-match.html.tmpl,v  <--  confirm-user-match.html.tmpl
new revision: 1.14; previous revision: 1.13
done
Checking in template/en/default/global/per-bug-queries.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/per-bug-queries.html.tmpl,v  <--  per-bug-queries.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/list/change-columns.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/change-columns.html.tmpl,v  <--  change-columns.html.tmpl
new revision: 1.13; previous revision: 1.12
done
Checking in template/en/default/list/edit-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/edit-multiple.html.tmpl,v  <--  edit-multiple.html.tmpl
new revision: 1.34; previous revision: 1.33
done
Checking in template/en/default/list/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.49; previous revision: 1.48
done
Checking in template/en/default/list/quips.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/quips.html.tmpl,v  <--  quips.html.tmpl
new revision: 1.17; previous revision: 1.16
done
Checking in template/en/default/pages/linkify.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/pages/linkify.html.tmpl,v  <--  linkify.html.tmpl
new revision: 1.8; previous revision: 1.7
done
Checking in template/en/default/pages/quicksearch.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/pages/quicksearch.html.tmpl,v  <--  quicksearch.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/pages/quicksearchhack.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/pages/quicksearchhack.html.tmpl,v  <--  quicksearchhack.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/reports/create-chart.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/create-chart.html.tmpl,v  <--  create-chart.html.tmpl
new revision: 1.13; previous revision: 1.12
done
Checking in template/en/default/reports/duplicates.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/duplicates.html.tmpl,v  <--  duplicates.html.tmpl
new revision: 1.16; previous revision: 1.15
done
Checking in template/en/default/reports/series.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/series.html.tmpl,v  <--  series.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/request/queue.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/request/queue.html.tmpl,v  <--  queue.html.tmpl
new revision: 1.16; previous revision: 1.15
done
Checking in template/en/default/search/boolean-charts.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/boolean-charts.html.tmpl,v  <--  boolean-charts.html.tmpl
new revision: 1.14; previous revision: 1.13
done
Checking in template/en/default/search/form.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/form.html.tmpl,v  <--  form.html.tmpl
new revision: 1.40; previous revision: 1.39
done
Checking in template/en/default/search/knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/knob.html.tmpl,v  <--  knob.html.tmpl
new revision: 1.18; previous revision: 1.17
done
Checking in template/en/default/search/search-report-graph.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-report-graph.html.tmpl,v  <--  search-report-graph.html.tmpl
new revision: 1.9; previous revision: 1.8
done
Checking in template/en/default/search/search-report-table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-report-table.html.tmpl,v  <--  search-report-table.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/search/search-specific.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-specific.html.tmpl,v  <--  search-specific.html.tmpl
new revision: 1.16; previous revision: 1.15
done
Checking in template/en/default/whine/schedule.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/whine/schedule.html.tmpl,v  <--  schedule.html.tmpl
new revision: 1.5; previous revision: 1.4
done