317708 - cairo renderer leaks memory and uses uninitialised variables with text in SVG

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Robert Longson [:longsonr]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051124 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051124 Firefox/1.6a1

nsSVGCairoGlyphGeometry::Render and 
nsSVGCairoGlyphGeometry::GetBoundingBox
both contain two calls to Source->GetCharacterPosition. Memory allocated in the first call is never freed.

Also it looks like if GetCharacterPosition returns a non null result then we should not call mSource->GetX or GetX as these functions return uninitialised values in this case (the individual textPath positions being encoded in the GetCharacterPosition data).


Reproducible: Always

Steps to Reproduce:
1. Display an SVG file which contains text or textPath elements




does not affect 1.5 branch.

Comment 1

[Robert Longson [:longsonr]]

Attachment: remove extraneous function calls and only call GetX/Y if cp is null

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 204136 [details] [diff] [review]
remove extraneous function calls and only call GetX/Y if cp is null

sr=jst

Comment 3

[tor]

Checked in for Robert.

Comment 4

[tor]

Attachment: merge to branch

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 215293 [details] [diff] [review]
merge to branch

Really, we should be using nsAutoPtr for cp.

Comment 6

[tor]

Checked in on branch.