317831 - Advanced Search Query Builder UI

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

A dialog that allows complicated and/or tests to be constructed.

Comment 1

[Annie Sullivan]

Attachment: Advanced query builder

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

the UI here needs to be reworked a little. 

clicking the "+" button next to Save should expand out a single row:

+------------------------------------------------------------------+
| Advanced Search                                       ( Save )(-)|
|------------------------------------------------------------------|
| [ Keywords          :^] include [                         ](+)(-)|
|                                                                  |
| [ ] Search Bookmarks only     [x] Maximum results: [ 100 ]       |
+------------------------------------------------------------------+

When expanded fully:

+------------------------------------------------------------------+
| Advanced Search, match: [ all :^] of the following:   ( Save )(-)|
|------------------------------------------------------------------|
| [ Keywords          :^] include [                         ](+)(-)|
| [ Visited           :^] [ in the last :^] [ 7  ] [ days :^](+)(-)|
| [ Site              :^] [ is :^] [                        ](+)(-)|
| [ Location          :^] [ starts with ^] [ http://        ](+)(-)|
|                                                                  |
| [ ] Search Bookmarks only     [x] Maximum results: [ 100 ]       |
+------------------------------------------------------------------+

The sorting/grouping options are specified by the rest of the UI (sort column headers, grouping buttons at the base). 

Comment 3

[Annie Sullivan]

Attachment: Advanced query builder--addresses Ben's comments

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 208784 [details] [diff] [review]
Advanced query builder--addresses Ben's comments

See comment below.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

I want it to look /exactly/ like I ascii'ed. That means no groupbox, "match" on the same line as "Advanced Search" etc. Bookmark restrict as a checkbox, to the left of Maximum Results.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Also, once you can't add any more criteria, the + buttons should disable. 

Comment 7

[Annie Sullivan]

Attachment: Advanced query builder

Sorry, I didn't read the ascii art carefully enough :)

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 208809 [details] [diff] [review]
Advanced query builder

>+  _dateFormat: "M/D/Y", // TODO -- make localizeable

Make this localizable not using localizable templates, but instead using nsIScriptableDateFormat, a service that takes time components and outputs the appropriately localized string. Also, localize now, not later. 

Can you shove all the JavaScript relating to the advanced search builder into a separate object? e.g. PlacesQueryBuilder or something? Just for neatness. 

>+      switch (querySubject) {

... this part of the function is very long which can hinder readability. Can you break this up into smaller chunks perhaps, maybe having a hash of id->functions that takes a query object and sets the appropriate items.  

I checked in some slight changes to the header the other day so you'll need to update and merge to get them... this might require a small amount of code change, but nothing too complicated. 

I have some visual appearance issues but we can talk about those later or I can fix them myself while you move onto something else. This looks good, but can you make one more patch that addresses the above and then you can check this in.

Comment 9

[Annie Sullivan]

Attachment: Advanced query builder

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 208915 [details] [diff] [review]
Advanced query builder

r=[e-mail]

Comment 11

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv