317948 - [FIX]Possible to readd frames to frame map after they've been removed

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Boris Zbarsky [:bzbarsky]]

If removing a frame triggers a quote or counter list rebuild (which it will if BeginUpdate/EndUpdate are not called around whatever it is that removes the frame), then we'll end up calling GetPrimaryFrameFor in the quote/counter list code (when it sets data), which will readd the entry to the primary frame map.

This is easiest to hit from the restyle event processing code.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 2

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Branch version of the patch

As bug 362155 shows, we probably want this on branches...  This is a quite safe fix that only affects the behavior when CSS quotes (or HTML <q>) are involved and just makes sure we don't try to mess with frames while we're destroying them.

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 247135 [details] [diff] [review]
Branch version of the patch

approved for 1.8/1.8.0 branches, a=dveditz

Comment 5

[Boris Zbarsky [:bzbarsky]]

Fixed on 1.8 and 1.8.0 branches.