Closed Bug 317948 Opened 14 years ago Closed 14 years ago

[FIX]Possible to readd frames to frame map after they've been removed

Categories

(Core :: Layout, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

(Keywords: fixed1.8.0.9, fixed1.8.1.1)

Attachments

(2 files)

If removing a frame triggers a quote or counter list rebuild (which it will if BeginUpdate/EndUpdate are not called around whatever it is that removes the frame), then we'll end up calling GetPrimaryFrameFor in the quote/counter list code (when it sets data), which will readd the entry to the primary frame map.

This is easiest to hit from the restyle event processing code.
Attached patch FixSplinter Review
Attachment #204298 - Flags: superreview?(dbaron)
Attachment #204298 - Flags: review?(dbaron)
Attachment #204298 - Flags: superreview?(dbaron)
Attachment #204298 - Flags: superreview+
Attachment #204298 - Flags: review?(dbaron)
Attachment #204298 - Flags: review+
Fixed.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Blocks: 362155
As bug 362155 shows, we probably want this on branches...  This is a quite safe fix that only affects the behavior when CSS quotes (or HTML <q>) are involved and just makes sure we don't try to mess with frames while we're destroying them.
Attachment #247135 - Flags: approval1.8.1.1?
Attachment #247135 - Flags: approval1.8.0.9?
Comment on attachment 247135 [details] [diff] [review]
Branch version of the patch

approved for 1.8/1.8.0 branches, a=dveditz
Attachment #247135 - Flags: approval1.8.1.1?
Attachment #247135 - Flags: approval1.8.1.1+
Attachment #247135 - Flags: approval1.8.0.9?
Attachment #247135 - Flags: approval1.8.0.9+
Fixed on 1.8 and 1.8.0 branches.
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.