318077 - PR_MemMap is busted on WINCE

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Doug Turner (:dougt)]

On the NSPRPUB_PRE_4_2_WINCE_BRANCH branch, PR_MemMap is busted.

Comment 1

[Doug Turner (:dougt)]

When this is fixed, we can revert the following change:

Checking in mozJSComponentLoader.cpp;
/cvsroot/mozilla/js/src/xpconnect/loader/mozJSComponentLoader.cpp,v  <--  mozJSComponentLoader.cpp
new revision: 1.116; previous revision: 1.115
done

Comment 2

[Doug Turner (:dougt)]

not actively working on this, feel free to help yourself.

Comment 3

[Doug Turner (:dougt)]

this doesn't appear to be a problem under windows mobile 6.1 (emulator).

Comment 4

[Doug Turner (:dougt)]

Attachment: revert the change to mozjscomponentloader

this reverts a change on windows mobile to avoid using PR_MEMMAP.  I have been running with this patch for a few days and haven't see any issues.

Comment 5

[Doug Turner (:dougt)]

looks like my testing wasn't that deep using fennec.

http://mxr.mozilla.org/mozilla-central/source/nsprpub/pr/src/md/windows/ntmisc.c#669

Comment 6

[Doug Turner (:dougt)]

nevermind -- we don't do anything special in our loader:

http://mxr.mozilla.org/mozilla-central/source/js/src/xpconnect/loader/mozJSComponentLoader.cpp#1246

(Windows Mobile only doesn't support the FILE_MAP_COPY option)

Comment 7

[Doug Turner (:dougt)]

Comment on attachment 362681 [details] [diff] [review]
revert the change to mozjscomponentloader

http://hg.mozilla.org/mozilla-central/rev/759b4837b13d

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 362681 [details] [diff] [review]
revert the change to mozjscomponentloader

a191=beltzner

Comment 9

[Doug Turner (:dougt)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/158378b4ea84