PR_MemMap is busted on WINCE

RESOLVED FIXED

Status

RESOLVED FIXED
13 years ago
8 months ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

({fixed1.9.1})

Trunk
x86
Windows Mobile 6 Standard
fixed1.9.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
On the NSPRPUB_PRE_4_2_WINCE_BRANCH branch, PR_MemMap is busted.
(Assignee)

Comment 1

13 years ago
When this is fixed, we can revert the following change:

Checking in mozJSComponentLoader.cpp;
/cvsroot/mozilla/js/src/xpconnect/loader/mozJSComponentLoader.cpp,v  <--  mozJSComponentLoader.cpp
new revision: 1.116; previous revision: 1.115
done
(Assignee)

Comment 2

11 years ago
not actively working on this, feel free to help yourself.
Assignee: doug.turner → nobody
OS: All → Windows Mobile 6 Standard

Updated

10 years ago
Flags: wanted-fennec1.0+
(Assignee)

Comment 3

10 years ago
this doesn't appear to be a problem under windows mobile 6.1 (emulator).
(Assignee)

Comment 4

10 years ago
Created attachment 362681 [details] [diff] [review]
revert the change to mozjscomponentloader

this reverts a change on windows mobile to avoid using PR_MEMMAP.  I have been running with this patch for a few days and haven't see any issues.
Assignee: nobody → doug.turner
(Assignee)

Comment 5

10 years ago
looks like my testing wasn't that deep using fennec.

http://mxr.mozilla.org/mozilla-central/source/nsprpub/pr/src/md/windows/ntmisc.c#669
(Assignee)

Comment 6

10 years ago
nevermind -- we don't do anything special in our loader:

http://mxr.mozilla.org/mozilla-central/source/js/src/xpconnect/loader/mozJSComponentLoader.cpp#1246

(Windows Mobile only doesn't support the FILE_MAP_COPY option)
(Assignee)

Updated

10 years ago
Attachment #362681 - Flags: review?(bugmail)
Attachment #362681 - Flags: review?(bugmail) → review+
(Assignee)

Comment 7

10 years ago
Comment on attachment 362681 [details] [diff] [review]
revert the change to mozjscomponentloader

http://hg.mozilla.org/mozilla-central/rev/759b4837b13d
Attachment #362681 - Flags: approval1.9.1?
(Assignee)

Updated

10 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Comment on attachment 362681 [details] [diff] [review]
revert the change to mozjscomponentloader

a191=beltzner
Attachment #362681 - Flags: approval1.9.1? → approval1.9.1+

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.