318241 - Firefox crashes downloading two files with the same name + Show Download Manager option [@ 0x00000043 - nsDownload::GetTempFile]

Status: VERIFIED WORKSFORME

(Toolkit :: Downloads API, defect)

Description

[Piotr Komoda]

I suffer from this bug from Firefox 1.5 Beta 2, I've reported this in Mozilla Quality blog, but utill today I didn't know the exact way to reproduce it.

Firefox 1.5 (Final, RC3, RC2, RC1, Beta 2, maybe even earlier) will crash when you try to download two files with the same name, but you must choose "open with" option.

Steps to reproduce:
1. Make sure you have some archiver installed in your system, that is capable of opening tar.gz files (WinRar in my case).
2. Make sure you have talkback installed.
3. Open the following two directories in tabs:
http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/1.5/linux-i686/en-US/
http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/1.5/linux-i686/pl/
4. Click on firefox-1.5.tar.gz in en-US, when download manager window will pop-up, choose Open with (your archiver name here)
5. Do the same with file in /pl. IMPORTANT: Do this before en-US file will be downloaded.

Firefox will crash and MQFA window will appear.

Some talkback ID's for you:
12346273
12402580
12402585
12402589

Comment 1

[timeless]

Incident ID: 12402580
Stack Signature	0x00000043 ce9d7c86
Product ID	Firefox15
Build ID	2005111116
Trigger Time	2005-11-29 16:15:37.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	
URL visited	
User Comments	
Since Last Crash	18541 sec
Total Uptime	287679 sec
Trigger Reason	Access violation
Source File, Line No.	N/A
Stack Trace 	
0x00000043
nsDownload::GetTempFile  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp, line 1866]
nsDownloadManager::AddDownload  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp, line 557]
nsDownloadProxy::Init  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/toolkit/components/build/../downloads/src\nsDownloadProxy.h, line 77]
nsExternalAppHandler::InitializeDownload  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp, line 2102]
nsExternalAppHandler::CreateProgressListener  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp, line 2127]
nsExternalAppHandler::LaunchWithApplication  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp, line 2431]
XPTC_InvokeByIndex  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp, line 102]
XPCWrappedNative::CallMethod  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp, line 2139]
XPC_WN_CallMethod  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp, line 1444]
js_Invoke  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/jsinterp.c, line 1177]
js_Interpret  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/jsinterp.c, line 3523]
js_Invoke  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/jsinterp.c, line 1197]
nsXPCWrappedJSClass::CallMethod  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/xpconnect/src/xpcwrappedjsclass.cpp, line 1369]
nsXPCWrappedJS::CallMethod  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/js/src/xpconnect/src/xpcwrappedjs.cpp, line 462]
SharedStub  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcstubs.cpp, line 147]
nsEventListenerManager::HandleEventSubType  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/content/events/src/nsEventListenerManager.cpp, line 1685]
nsEventListenerManager::HandleEvent  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/content/events/src/nsEventListenerManager.cpp, line 1786]
nsXULElement::HandleDOMEvent  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/content/xul/content/src/nsXULElement.cpp, line 2153]
PresShell::HandleDOMEventWithTarget  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/base/nsPresShell.cpp, line 6466]
nsButtonBoxFrame::DoMouseClick  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/xul/base/src/nsButtonBoxFrame.cpp, line 182]
nsButtonBoxFrame::MouseClicked  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/xul/base/src/nsButtonBoxFrame.h, line 61]
PresShell::HandleEventInternal  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/base/nsPresShell.cpp, line 6408]
PresShell::HandleEventWithTarget  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/base/nsPresShell.cpp, line 6265]
nsEventStateManager::CheckForAndDispatchClick  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/content/events/src/nsEventStateManager.cpp, line 3039]
nsEventStateManager::PostHandleEvent  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/content/events/src/nsEventStateManager.cpp, line 2016]
PresShell::HandleEventInternal  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/base/nsPresShell.cpp, line 6439]
PresShell::HandleEvent  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/base/nsPresShell.cpp, line 6203]
nsViewManager::HandleEvent  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/view/src/nsViewManager.cpp, line 2559]
nsViewManager::DispatchEvent  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/view/src/nsViewManager.cpp, line 2246]
HandleEvent  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/view/src/nsView.cpp, line 174]
nsWindow::DispatchEvent  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/widget/src/windows/nsWindow.cpp, line 1252]
nsWindow::DispatchMouseEvent  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/widget/src/windows/nsWindow.cpp, line 5982]
ChildWindow::DispatchMouseEvent  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/widget/src/windows/nsWindow.cpp, line 6233]
nsWindow::WindowProc  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/widget/src/windows/nsWindow.cpp, line 1434]
USER32.dll + 0x8734 (0x77d38734)
USER32.dll + 0x8816 (0x77d38816)
USER32.dll + 0x89cd (0x77d389cd)
USER32.dll + 0x8a10 (0x77d38a10)
nsAppShell::Run  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/widget/src/windows/nsAppShell.cpp, line 159]
nsAppStartup::Run  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/toolkit/components/startup/src/nsAppStartup.cpp, line 151]
main  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/browser/app/nsBrowserApp.cpp, line 61]
kernel32.dll + 0x16d4f (0x7c816d4f)

Comment 2

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8) Gecko/20051130 Firefox/1.5 ID:2005113003

Not seeing this.
FF refuses to display the second download, so i'm not sure it's even doing at all.(DM shows 1 file loading)
No crash, winzip shows up if the download is complete.

Comment 3

[Piotr Komoda]

(In reply to comment #2)
> Not seeing this.
> FF refuses to display the second download, so i'm not sure it's even doing at
> all.(DM shows 1 file loading)
> No crash, winzip shows up if the download is complete.

OK, after some investigation I know why you don't see this. Here's additional step to reproduce:
2.1 Make sure that "Show Download Manager when a download begins" in Options -> Downloads is unchecked.

Comment 4

[Piotr Komoda]

Any chances to fix it for 1.5.0.1?

Comment 5

[timeless]

not a very good chance. i'd suggest you catch this in a debugger (e.g. using mcsmurf's build) and then visit irc and ask for someone to talk you through analyzing the problem.

Comment 6

[Daniel Veditz [:dveditz]]

a tested, reviewed patch would be considered for a 1.8.0.x release, but not a blocker.

Comment 7

[Jesse Ruderman on Windows]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20090913 Minefield/3.7a1pre

WFM on Vista.  The files are given sequential filenames and both opened.  I tried with both "ask - rinrar" and "open with wordpad every time".

Btw, nsDownload::GetTempFile no longer exists.

Comment 8

[Kevin Brosnan]

v. Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3