318403 - profile not found on non-English Windows

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[Robert Kaiser]

On a non-English Windows, the profile does not reside in "Application Data" but a directory with a localized name.
Contrary to that, the block starting in http://lxr.mozilla.org/mozilla/source/tools/tinderbox/build-seamonkey-util.pl#1110 hardcodes us to use "Application Data" (lines 1113 and 1117).
Lines 1116-1120 are especially interesting, as I fail to see why we are not using %APPDATA% all the time - and it also works well with localized Windows versions.

I have tpol (on the Mozilla1.8-SeaMonkey tree) running on a German WinXP, and it only made it throught the tests correctly once I forced it to use %APPADATA% instead of the construct in line 1117 (I did that by adding a -d check for the english-named dir to line 1116, but from what others tell me, I come to think defaulting to %APPDIR% would be better)

Comment 1

[Robert Kaiser]

Attachment: try %APPDATA% first, use %USERPROFILE% only as fallback

This patch makes us work also on localized NT-based OSes, as it reverses the logic to first try %APPDATA% and only use %USERPROFILE% with hardcoded "Application Data" subdirectory as a fallback solution.

Comment 2

[Robert Kaiser]

Checked in.