318479 - `make install' doesn't install NSS headers

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Bastiaan Jacques]

`make install' should install the headers in dist/public/nss so that other programs can link against NSS.

Comment 1

[Bastiaan Jacques]

Attachment: fix

This patch ensures that the headers are installed to (for instance) /usr/include/firefox-1.5/nss. This location is referred to by the pkg-config firefox-nss.pc file, which the installation process already provides.

Comment 2

[Kai Engert [:KaiE:]]

Comment on attachment 204640 [details] [diff] [review]
fix

I think Wan-Teh should review patches to the NSS build system.

Comment 3

[Wan-Teh Chang]

Kai, this is a patch for PSM (mozilla/security/manager/Makefile.in).

I don't know if this patch is the right solution.  I think the right
solution is to build NSS as an RPM and then build Firefox with "system NSS".

Comment 4

[Kai Engert [:KaiE:]]

After reading Wan-Teh's comment I think he is right.

Bastiaan, two comments from me:

- In general we discourage other portions of the Mozilla code to directly link against NSS that comes as part of a Mozilla application, because NSS must be carefully wrapped by XPCOM interfaces to ensure consistency. So if you require additional functionality that accesses NSS, it would be best to implement new XPCOM code in mozilla/security/manager

- However, I suspect your request is OS distribution specific, because you refer to the global location /usr/include/firefox-1.5. In this case I think a distribution specific patch should be used to install the NSS headers globally. Note that NSS is now being seen as an independent library, rather than a subset of Mozilla.

I would like to resolve this as WONTFIX.
But please feel free to provide further explanations.