31863 - clicking search button while on a search page does a search on the url

Status: VERIFIED FIXED

(SeaMonkey :: Search, defect, P2)

Description

[Claudius Gayle]

Matt: this is the same issue we talked about - every other scenario is fixed
Overview Description: 
	If you surf to search.netscape.com by clicking the search button, and then click it again, a search is performed with the url 
as the string.
  

Steps to Reproduce: 

1) Click the browser Search button. Let the page load.

2) Click it again.


Actual Results: 

	You've done a search on the text that was in the url field even though you didn't type it. You searched on 'http://
info.netscape.com/fwd/6_0b1/http://search.netscape.com/'

Expected Results: 

	if you haven't typed in the url field, clicking the search button should take you to your chosen proveder (default Netscape). 
So in this scenario you should just go to the page you're already at, search.netscape.com.

Build Date & Platform Bug Found: 

	This bug has been around for a while but exists on all builds and all platforms for 20000313 builds.

Additional Information:

	I think something about the domain info.netscape.com is the trigger for this bug. I you just type that in and surf to it, then 
click the Search button you will see this bug. I've reporduced this bug with different search providers(such that you don't go to 
search.netscape.com) and the common element is you always redirect through info.netscape.com. If info.netscape.com is in the 
url bar and you click search you always end up doing a search on the url.

Comment 1

[matt]

I believe this happenes because the url
field is not getting updated from a redirect.
I'm getting the search entry from the url and comparing
it to the url of the page.  Thus it is different for this page.

Comment 2

[Claudius Gayle]

gotcha. I happen to be session history QA too and i know there's a bug for that. I'll find it and then this bug will depend on that 
one.

Comment 3

[matt]

Claudius

Do you have the depend on this bug?

Comment 4

[Claudius Gayle]

that should be it(noted in depends field) although i thought it would be an older bug.

Comment 5

[don]

Move to M20 target milestone.

Comment 6

[Marcia Knous [:marcia]]

Netscape Nav triage team: this is a Netscape beta stopper.  Can we please mark 
the similar session bug as a minus?

Comment 7

[Viswanath Ramachandran]

matts almost done with this one. 

Comment 8

[Paul Chen]

Mass moving most of mozilla0.9 bugs to mozilla0.8.1

Comment 9

[matt]

Attachment: Is it a URL or is it a Search? That is the question!

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Looks like you've got some indentation issues in the patch (at least according 
to Netscape 4.7)... normalize those and r=ben

Comment 11

[Alec Flett]

agreed on the spacing/indentation issues.. r=alecf with them fixed up

Comment 12

[matt]

I actaully corrected them.
Changed them from tabs (bad) to spaces (good).
I'll go over it again just to make sure.

Comment 13

[Paul Chen]

Tree is closed for 0.8.1, since I don't consider this bug critical for 0.8.1,
moving to 0.9

Comment 14

[matt]

fixed this and checked in

Comment 15

[Claudius Gayle]

man, search has some issues - but it's working just enough to mark this VERIFIED Fixed
with 2001041008 builds