318680 - "Organisation" should be spelled "Organization" in the alert for empty fields in Address Book.

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

In the alert that comes up when you have one of the newly-required fields left blank, "Organization" is spelled "Organisation" (British spelling).

This was added in bug 314995.

It's not that I necessarily want to assert the American spelling but:

1) The field itself is spelled "Organization"
2) The precedent is for American spelling of words, with the exception of "colour" and a few others.

Patch forthecoming.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Thunderbird patch (trunk)

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: SeaMonkey patch (trunk)

Comment 3

[Scott MacGregor]

Comment on attachment 204762 [details] [diff] [review]
Thunderbird patch (trunk)

thanks stephen!

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Scott/Mark, can you guys please land these patches for me?  Pretty please? ;-)

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 204763 [details] [diff] [review]
SeaMonkey patch (trunk)

Thanks Stephen. I'll check the patches in in a couple of hours if scott hasn't done so already.

Comment 6

[Mark Banner (:standard8)]

This is actually a core address book bug ;-)

Comment 7

[Mark Banner (:standard8)]

Both patches checked in:

/cvsroot/mozilla/mail/components/addrbook/content/abCardOverlay.js,v  <--  abCardOverlay.js
new revision: 1.13; previous revision: 1.12
done
Checking in mail/locales/en-US/chrome/messenger/addressbook/addressBook.properties;
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/addressbook/addressBook.properties,v  <--  addressBook.properties
new revision: 1.9; previous revision: 1.8
/cvsroot/mozilla/mailnews/addrbook/resources/content/abCardOverlay.js,v  <--  abCardOverlay.js
new revision: 1.61; previous revision: 1.60
done
Checking in mailnews/addrbook/resources/locale/en-US/addressBook.properties;
/cvsroot/mozilla/mailnews/addrbook/resources/locale/en-US/addressBook.properties,v  <--  addressBook.properties
new revision: 1.37; previous revision: 1.36

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Thanks guys!

Marking FIXED

Comment 9

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

First a=me for the SeaMonkey patch

Comment 10

[[e-mail]]

a=me for SeaMonkey

Comment 11

[Mark Banner (:standard8)]

SeaMonkey only patch checked into the 1.8 branch in time for SeaMonkey 1.0b.

Comment 12

[Mark Banner (:standard8)]

(In reply to comment #11)
> SeaMonkey only patch checked into the 1.8 branch in time for SeaMonkey 1.0b.
> 
Also now checked into the 1.8.0 branch.

Comment 13

[Mark Banner (:standard8)]

Comment on attachment 204762 [details] [diff] [review]
Thunderbird patch (trunk)

This patch corrects the spelling of a previous patch, l10n change but should be low risk.

Comment 14

[Mark Banner (:standard8)]

Thunderbird patch checked into 1.8.1 branch.