"Organisation" should be spelled "Organization" in the alert for empty fields in Address Book.

RESOLVED FIXED

Status

MailNews Core
Address Book
--
trivial
RESOLVED FIXED
12 years ago
9 years ago

People

(Reporter: stephend, Assigned: stephend)

Tracking

({fixed-seamonkey1.0, fixed1.8.1})

Trunk
fixed-seamonkey1.0, fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

12 years ago
In the alert that comes up when you have one of the newly-required fields left blank, "Organization" is spelled "Organisation" (British spelling).

This was added in bug 314995.

It's not that I necessarily want to assert the American spelling but:

1) The field itself is spelled "Organization"
2) The precedent is for American spelling of words, with the exception of "colour" and a few others.

Patch forthecoming.
(Assignee)

Comment 1

12 years ago
Created attachment 204762 [details] [diff] [review]
Thunderbird patch (trunk)
Attachment #204762 - Flags: superreview?
Attachment #204762 - Flags: review?
(Assignee)

Comment 2

12 years ago
Created attachment 204763 [details] [diff] [review]
SeaMonkey patch (trunk)
Attachment #204763 - Flags: superreview?(mscott)
Attachment #204763 - Flags: review?
(Assignee)

Updated

12 years ago
Attachment #204762 - Flags: superreview?(mscott)
Attachment #204762 - Flags: superreview?
Attachment #204762 - Flags: review?(mscott)
Attachment #204762 - Flags: review?
(Assignee)

Updated

12 years ago
Attachment #204763 - Flags: review? → review?(bugzilla)

Comment 3

12 years ago
Comment on attachment 204762 [details] [diff] [review]
Thunderbird patch (trunk)

thanks stephen!
Attachment #204762 - Flags: superreview?(mscott)
Attachment #204762 - Flags: superreview+
Attachment #204762 - Flags: review?(mscott)
Attachment #204762 - Flags: review+

Updated

12 years ago
Attachment #204763 - Flags: superreview?(mscott) → superreview+
(Assignee)

Comment 4

12 years ago
Scott/Mark, can you guys please land these patches for me?  Pretty please? ;-)
Comment on attachment 204763 [details] [diff] [review]
SeaMonkey patch (trunk)

Thanks Stephen. I'll check the patches in in a couple of hours if scott hasn't done so already.
Attachment #204763 - Flags: review?(bugzilla) → review+
This is actually a core address book bug ;-)
Component: Address Book → MailNews: Address Book
OS: Windows XP → All
Product: Mozilla Application Suite → Core
Hardware: PC → All
Both patches checked in:

/cvsroot/mozilla/mail/components/addrbook/content/abCardOverlay.js,v  <--  abCardOverlay.js
new revision: 1.13; previous revision: 1.12
done
Checking in mail/locales/en-US/chrome/messenger/addressbook/addressBook.properties;
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/addressbook/addressBook.properties,v  <--  addressBook.properties
new revision: 1.9; previous revision: 1.8
/cvsroot/mozilla/mailnews/addrbook/resources/content/abCardOverlay.js,v  <--  abCardOverlay.js
new revision: 1.61; previous revision: 1.60
done
Checking in mailnews/addrbook/resources/locale/en-US/addressBook.properties;
/cvsroot/mozilla/mailnews/addrbook/resources/locale/en-US/addressBook.properties,v  <--  addressBook.properties
new revision: 1.37; previous revision: 1.36
(Assignee)

Comment 8

12 years ago
Thanks guys!

Marking FIXED
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
First a=me for the SeaMonkey patch

Comment 10

12 years ago
a=me for SeaMonkey
SeaMonkey only patch checked into the 1.8 branch in time for SeaMonkey 1.0b.
Whiteboard: fixed-seamonkey1.0
(In reply to comment #11)
> SeaMonkey only patch checked into the 1.8 branch in time for SeaMonkey 1.0b.
> 
Also now checked into the 1.8.0 branch.
Comment on attachment 204762 [details] [diff] [review]
Thunderbird patch (trunk)

This patch corrects the spelling of a previous patch, l10n change but should be low risk.
Attachment #204762 - Flags: approval-branch-1.8.1?(mscott)

Updated

12 years ago
Attachment #204762 - Flags: approval-branch-1.8.1?(mscott) → approval-branch-1.8.1+
Keywords: fixed-seamonkey1.0
Whiteboard: fixed-seamonkey1.0
Thunderbird patch checked into 1.8.1 branch.
Keywords: fixed1.8.1
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.