Closed Bug 318873 Opened 19 years ago Closed 19 years ago

Crash in [@ js_GetLocalizedErrorMessage] following 215173 checkin

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: tor, Unassigned)

References

(
URL
)

Details

(Keywords: crash, smoketest, testcase)

Crash Data

Attachments

(1 file)

add null check
909 bytes, patch
jst
: review+
jst
: superreview+
Details | Diff | Splinter Review 
There looks to be a missing null check in jsexn.c following the user defined error message checkin.

Crash seen on linux and win32.
Attached patch add null check — — Splinter Review 

        Attachment #204849 -
        Flags: review?(brendan)

    
    

    
  
Steps to reproduce:
(1) Edit > Preferences
(2) Change a couple preferences (in my case, I turned on strict warnings and JavaScript dump() in the debug panel)
(3) Click OK -> Crash.

Smoketest B.24, blocker
Severity: normal → blocker
Keywords: crash, 
          
            smoketest, 
          
            testcase

    
    

    
  
Comment on attachment 204849 [details] [diff] [review]
add null check

r+sr=jst. w/o this I crash every time I hit Ctrl+N for a new window. Brendan, feel free to back this out if this aint the right change, but I'm landing this now.

        Attachment #204849 -
        Flags: superreview+

        Attachment #204849 -
        Flags: review?(brendan)

        Attachment #204849 -
        Flags: review+

    
    

    
  
Fix landed, leaving bug open for brendan to make sure this is the fix we want here.

    
    

    
  
Omigod. Thanks for fixing this one.


    
    

    
  
Sorry about that.  Thanks for the save, tor and jst.

/be
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Flags: testcase-
Flags: blocking1.8.1?

    
    

    
  
Plused 1.8.1 for Bub 215173 - so plusing this one as well.
Flags: blocking1.8.1? → blocking1.8.1+

    
  
Summary: Crash in js_GetLocalizedErrorMessage following 215173 checkin → Crash in [@ js_GetLocalizedErrorMessage] following 215173 checkin

    
    

    
  
Not going to block FF2 beta1 for bug 215173, so we don't need to block for this bug either.
Flags: blocking1.8.1+ → blocking1.8.1-

    
    

    
  
not on 1.8.0
No longer blocks: js1.6rc1
Crash Signature: [@ js_GetLocalizedErrorMessage]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: