The default bug view has changed. See this FAQ.

Color of download icon in prefs should match toolbar icon

RESOLVED FIXED in Camino1.5

Status

Camino Graveyard
Toolbars & Menus
--
enhancement
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: davedit, Assigned: Jon Hicks)

Tracking

({fixed1.8.1, polish})

unspecified
Camino1.5
PowerPC
Mac OS X
fixed1.8.1, polish

Details

Attachments

(3 attachments, 3 obsolete attachments)

33.13 KB, image/png
Details
2.08 KB, image/tiff
Details
1.57 KB, image/tiff
Samuel Sidler (old account; do not CC)
: review+
Mike Pinkerton (not reading bugmail)
: superreview+
Details
(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20051201 Camino/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20051201 Camino/1.0+

I think the color of the download arror in dl_manager.tif should match the color of the Downloads pref pane icon for consistency. The green in new Downloads pref pane icon is nice, but if it were used in dl_manager.tif, it might clash with the charteruse. Perhaps a nice peach or gold? Just a suggestion.

Reproducible: Always
(Reporter)

Updated

12 years ago
Keywords: polish
I concur. Whatever color we choose, it should be consistent over both icons.

Jasper, can you look at this?
Assignee: mikepinkerton → camino
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Camino1.0

Comment 2

11 years ago
Created attachment 207069 [details]
proposal for new "downloads" icon

I tried to do the download metaphor in a different way. one that we already used actually. I propose to start using a box like we use for open to represent downloads. Attached is  a screenshot of the icon in action.

Comment 3

11 years ago
I think the box icon needs to be a little more isometric, because now it just looks 2D and I can't tell what the strip down the right side is. Nice idea though.

Comment 4

11 years ago
Created attachment 207100 [details]
2nd attempt

I had a quick chat with Mike and we both agree that the current look is much to 2d to actually come accross as a box. I gave it a second thought, and doing an isometric view would be strange as we don't use it anywhere in our icons. So what I did was just use the same solution as I did with the Open icon, which is add the open top.

Comment 5

11 years ago
Created attachment 207101 [details]
2nd preview

just to see
Attachment #207069 - Attachment is obsolete: true

Comment 6

11 years ago
Created attachment 207644 [details]
3d attempt

It's a minor change but for the good (thanks wevah for pointing this out.

I really don't think we should start doing icons in any "metric" kind of view. It will be very weird if we do so. I tried it, believe me.
Attachment #207100 - Attachment is obsolete: true
Attachment #207101 - Attachment is obsolete: true

Comment 7

11 years ago
Created attachment 207645 [details]
3d attempt tiff file

Just so people can try it out.
1.0 has shipped and I don't think we should change the icon(s) in a maintenance release. Moving this to 1.1.
Target Milestone: Camino1.0 → Camino1.1
I really don't like the box, personally.
QA Contact: toolbars
(Assignee)

Comment 10

11 years ago
Created attachment 238295 [details]
Revised dl_manager.tif icon with green arrow

As suggested, a version of the dl_manager.tif icon using the green arrow from the preferences icon for perusal.
Comment on attachment 238295 [details]
Revised dl_manager.tif icon with green arrow

This new downloads window icon is for the toolbar. It simply matches the color of the one in preferences. We can rethink what we want the download icon to look like in a future bug but for now, to be consistent, I say we land this update the icon.

r=me
Attachment #238295 - Flags: superreview?(mikepinkerton)
Attachment #238295 - Flags: review+
(Reporter)

Comment 12

11 years ago
The consistency is nice, but I think the color is too similar to manager.tif (unless this isn't a problem)
(In reply to comment #12)
> The consistency is nice, but I think the color is too similar to manager.tif
> (unless this isn't a problem)

I don't see that as a problem. They're different enough icons that visually you can see a difference (in shapes, specifically).
(Reporter)

Comment 14

11 years ago
Ya that's true. But I think we also use colors as visual cues (for example, red for stop or emergencies), and that green color signifies bookmarking to me in Camino.
(In reply to comment #14)
> for stop or emergencies), and that green color signifies bookmarking to me in
> Camino.

And back and forward... ;) We also use a slightly different green in our "add tab"  icon.

I really think this change is fine for now. We can revisit the icon later, but a brown icon isn't much of an improvement when green tends to mean "download" throughout the net.
Comment on attachment 238295 [details]
Revised dl_manager.tif icon with green arrow

sr=pink
Attachment #238295 - Flags: superreview?(mikepinkerton) → superreview+

Comment 17

11 years ago
Checked into trunk and MOZILLA_1_8_BRANCH
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: camino → jon
Status: REOPENED → NEW
Status: NEW → RESOLVED
Last Resolved: 11 years ago11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.