318888 - Color of download icon in prefs should match toolbar icon

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, enhancement)

Description

[davedit]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20051201 Camino/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20051201 Camino/1.0+

I think the color of the download arror in dl_manager.tif should match the color of the Downloads pref pane icon for consistency. The green in new Downloads pref pane icon is nice, but if it were used in dl_manager.tif, it might clash with the charteruse. Perhaps a nice peach or gold? Just a suggestion.

Reproducible: Always

Comment 1

[Samuel Sidler (old account; do not CC)]

I concur. Whatever color we choose, it should be consistent over both icons.

Jasper, can you look at this?

Comment 2

[Jasper]

Attachment: proposal for new "downloads" icon

I tried to do the download metaphor in a different way. one that we already used actually. I propose to start using a box like we use for open to represent downloads. Attached is  a screenshot of the icon in action.

Comment 3

[Simon Fraser [no longer active]]

I think the box icon needs to be a little more isometric, because now it just looks 2D and I can't tell what the strip down the right side is. Nice idea though.

Comment 4

[Jasper]

Attachment: 2nd attempt

I had a quick chat with Mike and we both agree that the current look is much to 2d to actually come accross as a box. I gave it a second thought, and doing an isometric view would be strange as we don't use it anywhere in our icons. So what I did was just use the same solution as I did with the Open icon, which is add the open top.

Comment 5

[Jasper]

Attachment: 2nd preview

just to see

Comment 6

[Jasper]

Attachment: 3d attempt

It's a minor change but for the good (thanks wevah for pointing this out.

I really don't think we should start doing icons in any "metric" kind of view. It will be very weird if we do so. I tried it, believe me.

Comment 7

[Jasper]

Attachment: 3d attempt tiff file

Just so people can try it out.

Comment 8

[Samuel Sidler (old account; do not CC)]

1.0 has shipped and I don't think we should change the icon(s) in a maintenance release. Moving this to 1.1.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I really don't like the box, personally.

Comment 10

[Jon Hicks]

Attachment: Revised dl_manager.tif icon with green arrow

As suggested, a version of the dl_manager.tif icon using the green arrow from the preferences icon for perusal.

Comment 11

[Samuel Sidler (old account; do not CC)]

Comment on attachment 238295 [details]
Revised dl_manager.tif icon with green arrow

This new downloads window icon is for the toolbar. It simply matches the color of the one in preferences. We can rethink what we want the download icon to look like in a future bug but for now, to be consistent, I say we land this update the icon.

r=me

Comment 12

[davedit]

The consistency is nice, but I think the color is too similar to manager.tif (unless this isn't a problem)

Comment 13

[Samuel Sidler (old account; do not CC)]

(In reply to comment #12)
> The consistency is nice, but I think the color is too similar to manager.tif
> (unless this isn't a problem)

I don't see that as a problem. They're different enough icons that visually you can see a difference (in shapes, specifically).

Comment 14

[davedit]

Ya that's true. But I think we also use colors as visual cues (for example, red for stop or emergencies), and that green color signifies bookmarking to me in Camino.

Comment 15

[Samuel Sidler (old account; do not CC)]

(In reply to comment #14)
> for stop or emergencies), and that green color signifies bookmarking to me in
> Camino.

And back and forward... ;) We also use a slightly different green in our "add tab"  icon.

I really think this change is fine for now. We can revisit the icon later, but a brown icon isn't much of an improvement when green tends to mean "download" throughout the net.

Comment 16

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 238295 [details]
Revised dl_manager.tif icon with green arrow

sr=pink

Comment 17

[Nick Kreeger]

Checked into trunk and MOZILLA_1_8_BRANCH