318918 - [BEOS]sqlite does not build when MOZ_OBJDIR is different than source directory.

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[mmadia]

User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20051130 SeaMonkey/1.5a
Build Identifier: ftp://ftp.mozilla.org/.1/mozilla/pub/mozilla.org/mozilla/nightly/2005-11-30-05-trunk/

When building either Calendar or Sunbird
and mk_add_options MOZ_OBJDIR=/some/folder/other/than/the/source is specified in .mozconfig, 
sqlite3 will fail to build.
It attempts to look for the source files inside the MOZ_OBJDIR folder.
symlinking mozilla/db/sqlite3/src/* to MOZ_OBJDIR/db/sqlite3/src/ allows building to progress.
 

Reproducible: Always

Steps to Reproduce:
1. in .mozconfig, use mk_add_options MOZ_OBJDIR= to specify a folder different than the one containing the source files
2. start the build process
3. wait for it... 

Actual Results:  
gcc -o parse.o -c -DOSTYPE=\"BeOS5.0\" -DOSARCH=\"BeOS\" -DBUILD_ID=0000000000 -I../../../dist/include/sqlite3 -I../../../dist/include -I../../../dist/include/nspr -I../../../dist/sdk/include -fPIC -Wall -W -Wno-unused -Wpointer-arith -Wcast-align -Wno-multichar -Wno-long-long -pipe -DNDEBUG -DTRIMMED -O2 -include ../../../mozilla-config.h -DMOZILLA_CLIENT -Wp,-MD,.deps/parse.pp /source/mozilla/db/sqlite3/src/parse.c
/binaries/SunBird.R5/db/sqlite3/src/parse.y:34: sqliteInt.h: No such file or directory
/binaries/SunBird.R5/db/sqlite3/src/parse.y:35: parse.h: No such file or directory
/binaries/SunBird.R5/db/sqlite3/src/parse.y:42: parse error before `Expr'
/binaries/SunBird.R5/db/sqlite3/src/parse.y:42: warning: no semicolon at end of struct or union
....
/binaries/SunBird.R5/db/sqlite3/src/parse.y:772: arithmetic on pointer to an incomplete type
/binaries/SunBird.R5/db/sqlite3/src/parse.y:772: dereferencing pointer to incomplete type
...
make[5]: *** [parse.o] Error 1
make[5]: Leaving directory `/binaries/SunBird.R5/db/sqlite3/src' 

Expected Results:  
the build system should be read the source files from the source directory and not the MOZ_OBJDIR.

additional information at http://www.livejournal.com/community/bezilla/153101.html

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

works fine for me (on linux). My objdir is outside my sourcedir.

Comment 2

[Joey Minta]

WFM also on linux, gcc

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Works for me on linux/windows/OSX; don't use MOZ_OBJDIR, just run configure with a relative path.  e.g.

cd objdir
MOZCONFIG=../my-mozconfig ../mozilla/configure

Comment 4

[tqh]

Do I understand correctly that MOZ_OBJDIR is unsupported for these apps, or is it just something that is wrong for BeOS?

And is it a must to run configure directly?

Comment 5

[Iain MacDonnell]

I have the same problem trying to build calendar on Solaris:

cc -o pragma.o -c  -DOSTYPE=\"SunOS5\" -DOSARCH=\"SunOS\" -DBUILD_ID=2006010222   -I../../../dist/include/sqlite3 -I../../../dist/include -I../../../dist/include/nspr -I../../../dist/sdk/include    -KPIC  -xstrconst -xbuiltin=%all -mt  -DDEBUG -D_DEBUG -DDEBUG_ -DTRACING -g   -DMOZILLA_VERSION=\"1.9a1\" -DMOZILLA_VERSION_U=1.9a1 -DSOLARIS=1 -DNSCAP_DISABLE_DEBUG_PTR_TYPES=1 -DD_INO=d_ino -DSTDC_HEADERS=1 -DHAVE_ST_BLKSIZE=1 -DHAVE_SIGINFO_T=1 -DHAVE_INT16_T=1 -DHAVE_INT32_T=1 -DHAVE_INT64_T=1 -DHAVE_UINT=1 -DHAVE_UINT_T=1 -DHAVE_UINT16_T=1 -DHAVE_DIRENT_H=1 -DHAVE_SYS_BYTEORDER_H=1 -DHAVE_GETOPT_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1 -DHAVE_NL_TYPES_H=1 -DHAVE_MALLOC_H=1 -DHAVE_X11_XKBLIB_H=1 -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_STATFS_H=1 -DHAVE_LIBM=1 -DHAVE_LIBDL=1 -DHAVE_LIBSOCKET=1 -DFUNCPROTO=15 -DHAVE_XSHM=1 -D_REENTRANT=1 -DHAVE_RANDOM=1 -DHAVE_STRERROR=1 -DHAVE_LCHOWN=1 -DHAVE_FCHMOD=1 -DHAVE_SNPRINTF=1 -DHAVE_MEMMOVE=1 -DHAVE_RINT=1 -DHAVE_STAT64=1 -DHAVE_LSTAT64=1 -DHAVE_FLOCKFILE=1 -DHAVE_LOCALTIME_R=1 -DHAVE_STRTOK_R=1 -DHAVE_LANGINFO_CODESET=1 -DVA_COPY=va_copy -DHAVE_VA_COPY=1 -DHAVE_I18N_LC_MESSAGES=1 -DMOZ_DEFAULT_TOOLKIT=\"gtk2\" -DMOZ_WIDGET_GTK2=1 -DMOZ_ENABLE_XREMOTE=1 -DMOZ_X11=1 -DMOZ_THUNDERBIRD=1 -DMOZ_BUILD_APP=mail -DMOZ_XUL_APP=1 -DMOZ_STATIC_MAIL_BUILD=1 -DMOZ_DISTRIBUTION_ID=\"org.mozilla\" -DMOZ_ENABLE_XFT=1 -DMOZ_ENABLE_GNOMEUI=1 -DIBMBIDI=1 -DMOZ_VIEW_SOURCE=1 -DACCESSIBILITY=1 -DMOZ_XPINSTALL=1 -DMOZ_JSLOADER=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DMOZ_XTF=1 -DMOZ_UPDATE_CHANNEL=default -DMOZ_LOGGING=1 -DDETECT_WEBSHELL_LEAKS=1 -DMOZ_USER_DIR=\".mozilla\" -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1 -DSUNCTL=1 -DMOZ_DLL_SUFFIX=\".so\" -DXP_UNIX=1 -DUNIX_ASYNC_DNS=1 -DJS_THREADSAFE=1 -DMOZ_REFLOW_PERF=1 -DMOZ_REFLOW_PERF_DSP=1 -DMOZ_ACCESSIBILITY_ATK=1 -DMOZILLA_LOCALE_VERSION=\"1.9a1\" -DMOZILLA_REGION_VERSION=\"1.9a1\" -DMOZILLA_SKIN_VERSION=\"1.8\"  -D_MOZILLA_CONFIG_H_ -DMOZILLA_CLIENT /export/stuff/mozilla/lightning20060102a/mozilla/calendar/lightning/../../db/sqlite3/src/pragma.c
"parse.y", line 52: cannot find include file: "sqliteInt.h"
"parse.y", line 53: cannot find include file: "parse.h"
"parse.y", line 60: syntax error before or at: Expr
"parse.y", line 69: syntax error before or at: Token
...etc...


I use:

mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-${MOZ_PKG_APPNAME}

where "${MOZ_PKG_APPNAME}" is "thunderbird" in this case. I've had this problem trying to build sunbird in the past too.

Comment 6

[beanladen]

Same problem here (SEAMONKEY 1.0, Linux 2.4.32,gcc2.95.3, suite-opt build
directory). sqliteInt.h exists. It turns out that in parse.c, a lot of 
#line 344 "parse.y"
(and similar) definitions appear, which seem to be spurious leftovers from 
some script. It compiles without problem when I comment out those lines.

gcc -o parse.o -c  -DOSTYPE=\"Linux2.4\" -DOSARCH=\"Linux\" -DBUILD_ID=2006021300   -I../../../dist/include/sqlite3 -I../../../dist/include -I../../../dist/include/nspr -I/usr/lib//include   -I../../../dist/sdk/include -I/usr/X11R6/include   -fPIC -I/usr/X11R6/include -Wall -W -Wno-unused -Wpointer-arith -Wcast-align -Wno-long-long -pedantic -pthread -pipe  -DNDEBUG -DTRIMMED -ffunction-sections -O2  -I/usr/X11R6/include -include ../../../mozilla-config.h -DMOZILLA_CLIENT -Wp,-MD,.deps/parse.pp /New/home/grabow/mozilla/db/sqlite3/src/parse.c                 <==============
parse.y:34: sqliteInt.h: No such file or directory                
parse.y:35: parse.h: No such file or directory
parse.y:42: parse error before `Expr'
parse.y:42: warning: no semicolon at end of struct or union
parse.y:43: warning: type defaults to `int' in declaration of `pOffset'
parse.y:43: ANSI C forbids data definition with no type or storage class

My configuration is:

mk_add_options MOZ_CO_PROJECT=suite,calendar
mk_add_options MOZ_CO_MODULE=mozilla/other-licenses/libart_lgpl
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/suite-opt
ac_add_options --with-system-jpeg=/usr/lib/
ac_add_options --with-system-zlib=/usr/lib/
ac_add_options --with-system-png=/usr/lib/
ac_add_options --enable-application=suite
ac_add_options --enable-default-toolkit=gtk
ac_add_options --enable-calendar
ac_add_options --disable-xprint
ac_add_options --enable-crypto
ac_add_options --disable-jsd
ac_add_options --disable-activex
ac_add_options --disable-activex-scripting
ac_add_options --disable-tests
ac_add_options --enable-optimize=-O2
ac_add_options --disable-debug
ac_add_options --disable-venkman
ac_add_options --disable-xprint
ac_add_options --disable-gnomevfs
ac_add_options --with-gtk-prefix=/usr/local/lib
ac_add_options --enable-image-decoders=all
ac_add_options --disable-gtktest
ac_add_options --disable-glibtest
ac_add_options --disable-xft
ac_add_options --enable-reorder
ac_add_options --enable-strip
ac_add_options --enable-elf-dynstr-gc
ac_add_options --enable-svg
ac_add_options --enable-svg-renderer=cairo

Comment 7

[Sergei Dolgov]

another related bug
https://bugzilla.mozilla.org/show_bug.cgi?id=318918

Comment 8

[Sergei Dolgov]

sorry, ignore Comment 7:

Comment 9

[Doug Shelton]

*** Bug 327471 has been marked as a duplicate of this bug. ***

Comment 10

[Doug Shelton]

After commits related to bug 327188, this bug now prevents Firefox from being built with MOZ_OBJDIR different than source.  May impact others - definitely impacts BeOS development, since the Bezilla team builds three different versions from same source tree for different versions of BeOS in current use.

Comment 11

[Doug Shelton]

Attachment: allows build to work when MOZ_OBJDIR is specified in .mozconfig

Comment 12

[Sergei Dolgov]

confirming bug, marking critical, as it breaks building of some apps even under "normal" conditions

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

trunk
Checking in db/sqlite3/src/Makefile.in;
/cvsroot/mozilla/db/sqlite3/src/Makefile.in,v  <--  Makefile.in
new revision: 1.12; previous revision: 1.11
done

MOZILLA_1_8_BRANCH
Checking in db/sqlite3/src/Makefile.in;
/cvsroot/mozilla/db/sqlite3/src/Makefile.in,v  <--  Makefile.in
new revision: 1.7.2.4; previous revision: 1.7.2.3
done

Comment 14

[Doug Shelton]

(In reply to comment #13)
thank you, Biesi!