318958 - Implement TDEA algorithm tests for FIPS 140-2 validation

Status: RESOLVED FIXED

(NSS :: Test, defect)

Description

[glen beasley]

http://csrc.nist.gov/cryptval/des/tripledesval.html
http://csrc.nist.gov/publications/nistpubs/800-20/800-20.pdf

Comment 1

[glen beasley]

Attachment: tdea algorithm tests

I left the old implementation for FIPS 140-1 DES and Triple DES tests, once 
this patch is approved, I will remove the old code. I realize I could of 
used the old code, but this patch follows the way the AES tests was implemented, plus the FIPS 140-1 implementation did not have the MMT tests, and the Monte Carlo
implementation I believe has some bugs comparing it to NIST Special Pub 800-20.

Comment 2

[Wan-Teh Chang]

Comment on attachment 205276 [details] [diff] [review]
tdea algorithm tests

r=wtc.

Comment 3

[glen beasley]

/cvsroot/mozilla/security/nss/cmd/fipstest/fipstest.c,v  <--  fipstest.c
new revision: 1.4; previous revision: 1.3
done
RCS file: /cvsroot/mozilla/security/nss/cmd/fipstest/tdea.sh,v
done
Checking in tdea.sh;
/cvsroot/mozilla/security/nss/cmd/fipstest/tdea.sh,v  <--  tdea.sh
initial revision: 1.1
done

Comment 4

[glen beasley]

Attachment: removal of DES and Triple DES FIPS 140-1 code

Comment 5

[Wan-Teh Chang]

Comment on attachment 205770 [details] [diff] [review]
removal of DES and Triple DES FIPS 140-1 code

r=wtc.

Comment 6

[glen beasley]

/cvsroot/mozilla/security/nss/cmd/fipstest/fipstest.c,v  <--  fipstest.c
new revision: 1.5; previous revision: 1.4
done

Comment 7

[Wan-Teh Chang]

Attachment: Remove unnecessary output to the MCT RESPONSE file

1. Remove unused variable k.
2. Remove unnecessary copying to the tempKey buffer.
3. Remove unnecessary output to the RESPONSE file.

Comment 8

[Wan-Teh Chang]

Attachment: Remove unnecessary output to the MCT RESPONSE file, fix outputtext_2

I found that outputtext_2 was incorrect.  This broke
the NumKeys = 3 tests.

Comment 9

[Wan-Teh Chang]

Attachment: Make MCT work

Please review and test it.  Compare the .rsp file with the
.sam file.  If it works, please go ahead and check it in.

Comment 10

[glen beasley]

Attachment: added code to set the parity bits for the DES keys

NSS_3_11_BRANCH
Checking in fipstest.c;
/cvsroot/mozilla/security/nss/cmd/fipstest/fipstest.c,v  <--  fipstest.c
new revision: 1.3.2.4; previous revision: 1.3.2.3
done
tip:
/cvsroot/mozilla/security/nss/cmd/fipstest/fipstest.c,v  <--  fipstest.c
new revision: 1.10; previous revision: 1.9
done

Comment 11

[Wan-Teh Chang]

Comment on attachment 206450 [details] [diff] [review]
added code to set the parity bits for the DES keys

>+    //set the parity bits             
>+    for (k=0; k<24; k++) {
>+        key[k] = odd_parity(key[k]);
>+    }

You need to use a C comment:
      /* set the parity bits */

Comment 12

[glen beasley]

sorry, changed to C comment and checked in.