318962 - Implement SHS algorithm tests for FIPS 140-2 validation

Status: RESOLVED FIXED

(NSS :: Test, defect)

Description

[glen beasley]

http://csrc.nist.gov/cryptval/shs/shaval.htm
http://csrc.nist.gov/cryptval/shs/SHAVS.pdf

Comment 1

[glen beasley]

Attachment: Added FIPS 140-2 SHA tests and removed FIPS 140-1 SHA tests

Comment 2

[Wan-Teh Chang]

Comment on attachment 205883 [details] [diff] [review]
Added FIPS 140-2 SHA tests and removed FIPS 140-1 SHA tests

>+SECStatus sha_calcMD(unsigned char *MD, unsigned int MDLen, unsigned char *msg, unsigned int msgLen) 
>+{    
>+    SECStatus   sha_status;

sha_status should be initialized to SECFailure.

>+SECStatus sha_mct_test(unsigned int MDLen, unsigned char *seed, FILE *resp) 
...
>+    char buf[80];

Please add a comment to justify why 80 is big enough.

>+void sha_test(char *reqfn) 
>+{
...
>+    char buf[25608];      /* holds one line from the input REQUEST file.*/
>+    unsigned char msg[12800]; /* message to digest */

These two buffers are quite big.  We probably should
allocate them in the heap.

Comment 3

[glen beasley]

/cvsroot/mozilla/security/nss/cmd/fipstest/fipstest.c,v  <--  fipstest.c
new revision: 1.6; previous revision: 1.5
done
RCS file: /cvsroot/mozilla/security/nss/cmd/fipstest/sha.sh,v
done
Checking in sha.sh;
/cvsroot/mozilla/security/nss/cmd/fipstest/sha.sh,v  <--  sha.sh
initial revision: 1.1
done

Comment 4

[glen beasley]

Attachment: buffer to small for SHA512 monte carlo test

Comment 5

[glen beasley]

checked in on tip and NSS_3_11_BRANCH

Checking in fipstest.c;
/cvsroot/mozilla/security/nss/cmd/fipstest/fipstest.c,v  <--  fipstest.c
new revision: 1.3.2.3; previous revision: 1.3.2.2
done

Checking in fipstest.c;
/cvsroot/mozilla/security/nss/cmd/fipstest/fipstest.c,v  <--  fipstest.c
new revision: 1.9; previous revision: 1.8
done

Comment 6

[Wan-Teh Chang]

Attachment: PORT_Realloc(oldptr, 0) may return 0 on some platforms

PORT_Realloc(oldptr, 0) either returns 0 or a fixed
non-zero value that can be passed to PORT_Free.  On
HP-UX, PORT_Realloc(oldptr, 0) returns 0.  So that
should not be treated as memory allocation failure.

Comment 7

[Wan-Teh Chang]

Attachment: Call PORT_ZAlloc instead of PORT_Realloc

It turns out that we free the old 'msg'
pointer and set it to NULL before calling
PORT_Realloc, so
    PORT_Realloc(msg, msgLen);
is
    PORT_Realloc(NULL, msgLen)
which is equivalent to
    PORT_Alloc(msgLen)

Combined with the subsequent memset(msg, 0, msgLen)
call, this becomes PORT_ZAlloc(msgLen).  (That memset
call is in the wrong place anyway; it should be after
the test for msg == NULL.)

Comment 8

[Wan-Teh Chang]

Comment on attachment 206563 [details] [diff] [review]
Call PORT_ZAlloc instead of PORT_Realloc

Checked in on the tip and the NSS_3_11_BRANCH.

Checking in fipstest.c;
/cvsroot/mozilla/security/nss/cmd/fipstest/fipstest.c,v  <--  fipstest.c
new revision: 1.13; previous revision: 1.12
done

Checking in fipstest.c;
/cvsroot/mozilla/security/nss/cmd/fipstest/fipstest.c,v  <--  fipstest.c
new revision: 1.3.2.7; previous revision: 1.3.2.6
done

Comment 9

[Wan-Teh Chang]

Attachment: Fix signed/unsigned comparison warnings by MSVC

To review this patch, you need to verify that it is
safe for i and j to be unsigned.

i: it's initialized to 2, 3, or 4, and only changed
   by i++ or i+=2.

   it's only used as array index (buf[i]).

j: it's initialized to 0 and only changed by j++.

   it's only used as array index (msg[j], seed[j], key[j]).

Comment 10

[glen beasley]

Comment on attachment 212010 [details] [diff] [review]
Fix signed/unsigned comparison warnings by MSVC

the variables i and j are 
only used as "unsigned int" 
in sha_test and hmac_test.

Comment 11

[Wan-Teh Chang]

Comment on attachment 212010 [details] [diff] [review]
Fix signed/unsigned comparison warnings by MSVC

I checked in the "signed/unsigned compiler warning"
patch on the NSS trunk (3.12) and NSS_3_11_BRANCH
(3.11.1).

Checking in fipstest.c;
/cvsroot/mozilla/security/nss/cmd/fipstest/fipstest.c,v  <--  fipstest.c
new revision: 1.24; previous revision: 1.23
done

Checking in fipstest.c;
/cvsroot/mozilla/security/nss/cmd/fipstest/fipstest.c,v  <--  fipstest.c
new revision: 1.3.2.17; previous revision: 1.3.2.16
done