31929 - Wrong way to throw a message box in nsMessenger.cpp

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[jefft]

Subject: 
        How to Throw a Message Box
   Date: 
        Wed, 15 Mar 2000 02:32:18 -0800
   From: 
        [e-mail] (Travis Bogard)
     To: 
        <[e-mail]>, <[e-mail]>
    CC: 
        <[e-mail]>




I've noticed message boxes going into the tree in various places (the most
recent ones being in mailnews).  Please don't call on services for doing
message boxes.  This has implications for embedding.  When you want to throw
a message box, find your nearest docShell and do a nsCOMPtr<nsIPrompt>
prompter(do_GetInterface(docShell));  NOTE that is a do_GetInterface.  Or if
you have the nsIDocShellTreeOwner you can call do_GetInterface on it (that's
what docShell does behind the scenes anyway).

Travis

-*-*-*
Travis Bogard           mailto:[e-mail]
714.812.8200            AIM Screen Name: Travis
-*-*-*

Comment 1

[jefft]

fix checked in.

Comment 2

[jefft]

Did a grep on all mailnews code. All our nsIPrompt(s) are now getting from the 
docshell instead of directly from the service. There are fall back situations 
but we always try to get it from the doc shell first. If fail then go for the 
service. Marking this bug as verified.