319344 - hPrefWindow called as a function

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Bjarne D Mathiesen]

Error: hPrefWindow is not a function
Source File: chrome://calendar/content/pref/prefBird.xul
Line: 1

The error seems to be in line 36 according to jminta on #calendar

Comment 1

[Stefan Sitter [:ssitter]]

lxr log says:
  prefBird.xul Version 1.3:  onselect="PrefDialogService.switchPage();">
  prefBird.xul Version 1.4:  onselect="hPrefWindow();">

so it seems that this want to be "hPrefWindow.switchPage();" instead.

Comment 2

[Bjarne D Mathiesen]

OK - what ssitter proposed works :-)))
Before, I had only an almost blank preferences window that was totally non-functional
Now, I've got the fully functional preferences window :-)

Now we just need someone to fix this in CVS too

Comment 3

[Stefan Sitter [:ssitter]]

Attachment: change hPrefWindow() to hPrefWindow.switchPage()

Solution from comment #1 that was tested by Bjarne D Mathiesen.

Comment 4

[Joey Minta]

Comment on attachment 205241 [details] [diff] [review]
change hPrefWindow() to hPrefWindow.switchPage()

Thanks for grabbing this, especially since it was my fault originally.

r=jminta

Comment 5

[Joey Minta]

patch checked in