319554 - Keyboard modifier (shift,ctrl,alt) and left-clicking on a link creates an event that is NOT cancelable by event handler

Status: VERIFIED FIXED

(Firefox :: General, defect, P2)

Description

[Daniel Kabs, reporting bugs since 2002]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20051111 Firefox/1.5

The following link 

<a href="http://www.firefox.com" onclick="return false;">Show Bug</a>

has the onclick attribute set in order to define an event handler. Here, the handler just returns false to ask the UA to cancel the default event action.[*]

Now press a modifier key while clicking on the link and suddenly the link can be activated: it may open in a tab or even in a new window.



[*] Of course, it does not make any sense to have a link that can not be activated but it's just there as proof of concept.

Reproducible: Always

Steps to Reproduce:



Expected Results:  
Expected: Nothing should happen.

Comment 1

[Daniel Kabs, reporting bugs since 2002]

Attachment: testcase: JS-Event cancelation fails when modifier+left-clicking link.

This is a testcase that shows that you can not cancel the event which is created when (shift,ctrl,alt) and left-clicking on a link.

Comment 2

[Daniel Kabs, reporting bugs since 2002]

By the way, this report specifically refers to left-clicking and neither middle- nor right-clicking. :-)

See also:

bug 151142: talks about modifier+click on a link should not generate a "click" event AT ALL for links.

As it stands currently, FF does create the event and thus the event should be cancelable. At least, thats how I understand:

http://www.w3.org/TR/DOM-Level-2-Events/events.html#Events-flow-cancelation

Cheers
Daniel

 

Comment 3

[Daniel Kabs, reporting bugs since 2002]

I still see this on the current release of FF.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.3) Gecko/20060426 Firefox/1.5.0.3

Comment 4

[Daniel Kabs, reporting bugs since 2002]

I also see this problem on latest trunk.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060517 Minefield/3.0a1

Comment 5

[Matt Cosentino]

It's on the 2.0 branch as well.  I have an AJAX application and many of my links perform some JavaScript tasks and return false, but using ctrl-click or middle clicking on the link opens a new tab and does not perform the JavaScript.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1a2) Gecko/20060519 BonEcho/2.0a2 ID:2006051904

Comment 6

[Philip Withnall (unavailable)]

Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9a1) Gecko/20060530 Minefield/3.0a1 - Build ID: 0000000000
Confirmed. Quite odd.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Not a DOM events issue.  The code that opens the new tab or window doesn't check whether the default action has been prevented.  It's an app issue.   Reassigning to Firefox based on UA string, but Seamonkey has the same problem.

Comment 8

[[e-mail]]

Attachment: xpfe fix

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 229281 [details] [diff] [review]
xpfe fix

a=biesi for sm1.1

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Attachment: firefox patch

Comment 11

[Asaf Romano (gone)]

Comment on attachment 239528 [details] [diff] [review]
firefox patch

r=mano

Comment 12

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/browser.js 	1.709

Comment 13

[Daniel Kabs, reporting bugs since 2002]

Cheers mates! Thanks for fixing this bug.

Comment 14

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061205 Minefield/3.0a1