319600 - New SeaMonkey throbber lives in grey square in Classic theme

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Karsten Düsterloh]

The new SeaMonkey throbber is surrounded by grey square in Classic theme in recent (branch) builds (see attached screenshot). Windows (branch) builds are okay.

Comment 1

[Karsten Düsterloh]

Attachment: screenshot of problem

Comment 2

[Robert Kaiser]

Ouch...
Somehow we seems to get some background color into the throbber here, as the image itself is transparent. Unfortunately I don't have a mac box around here to try a fix, though I'd really like to come up with one... Could you try to hack communicator/brand.css in a way that the #navigator-throbber box has backgound-color:transparent or something similar?

Comment 3

[Karsten Düsterloh]

Attachment: make the throbber button square transparent in Classic

This patch makes the throbber button background transparent.

Comment 4

[Robert Kaiser]

Comment on attachment 205347 [details] [diff] [review]
make the throbber button square transparent in Classic

r=me given this works in the described cases (which I can't test unfortunately), it's doing the same as modern already has...

Comment 5

[Eyal Rozenberg]

BTW, why doesn't the throbber in classic theme has a visible square button edge (visible on mouseover, I mean)? A flat, round-seeming throbber is kind of annoying IMHO.

Comment 6

[[e-mail]]

Comment on attachment 205347 [details] [diff] [review]
make the throbber button square transparent in Classic

sr=me given that two people have tried it (e.g. Mnyromyr and stefanh).

Comment 7

[Ian Neal]

Just to confirm, this patch also fixes it for me on Windows XP.

Comment 8

[Robert Kaiser]

Comment on attachment 205347 [details] [diff] [review]
make the throbber button square transparent in Classic

a+ per talk in #seamonkey channel :)

Comment 9

[Stefan [:stefanh]]

(In reply to comment #6)
> (From update of attachment 205347 [details] [diff] [review] [edit])
> sr=me given that two people have tried it (e.g. Mnyromyr and stefanh).
> 

Yeah, this fixes the issue with the grey square. My only complaint is that since the throbber is of such low quality (heavily compressed) and the toolbar's background is light the tail is pretty much invisible. I do think that the grey square should go, so this is the right fix. But, can we produce a throbber of better quality?

Comment 10

[Karsten Düsterloh]

Eyal, Stefan: Please file new bugs for other enhancements that are not part of the regression being fixed here. (Even though I think that a button hover rectangle around the throbber is really WONTFIX.)

Comment 11

[Karsten Düsterloh]

Checked in on trunk and branch.

Comment 12

[Karsten Düsterloh]

Checked in on MOZILLA_1_8_0_BRANCH.