New SeaMonkey throbber lives in grey square in Classic theme

RESOLVED FIXED

Status

SeaMonkey
General
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Karsten Düsterloh, Assigned: Karsten Düsterloh)

Tracking

({fixed1.8})

unspecified
PowerPC
Mac OS X
fixed1.8
Bug Flags:
blocking-seamonkey1.0b +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

12 years ago
The new SeaMonkey throbber is surrounded by grey square in Classic theme in recent (branch) builds (see attached screenshot). Windows (branch) builds are okay.
(Assignee)

Comment 1

12 years ago
Created attachment 205322 [details]
screenshot of problem
(Assignee)

Updated

12 years ago
Flags: blocking-seamonkey1.0b?

Updated

12 years ago
Flags: blocking-seamonkey1.0b? → blocking-seamonkey1.0b+

Comment 2

12 years ago
Ouch...
Somehow we seems to get some background color into the throbber here, as the image itself is transparent. Unfortunately I don't have a mac box around here to try a fix, though I'd really like to come up with one... Could you try to hack communicator/brand.css in a way that the #navigator-throbber box has backgound-color:transparent or something similar?
(Assignee)

Comment 3

12 years ago
Created attachment 205347 [details] [diff] [review]
make the throbber button square transparent in Classic

This patch makes the throbber button background transparent.
Assignee: general → mnyromyr
Status: NEW → ASSIGNED
Attachment #205347 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #205347 - Flags: review?
(Assignee)

Updated

12 years ago
Attachment #205347 - Flags: review? → review?(kairo)

Comment 4

12 years ago
Comment on attachment 205347 [details] [diff] [review]
make the throbber button square transparent in Classic

r=me given this works in the described cases (which I can't test unfortunately), it's doing the same as modern already has...
Attachment #205347 - Flags: review?(kairo) → review+

Comment 5

12 years ago
BTW, why doesn't the throbber in classic theme has a visible square button edge (visible on mouseover, I mean)? A flat, round-seeming throbber is kind of annoying IMHO.

Comment 6

12 years ago
Comment on attachment 205347 [details] [diff] [review]
make the throbber button square transparent in Classic

sr=me given that two people have tried it (e.g. Mnyromyr and stefanh).
Attachment #205347 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+

Comment 7

12 years ago
Just to confirm, this patch also fixes it for me on Windows XP.

Comment 8

12 years ago
Comment on attachment 205347 [details] [diff] [review]
make the throbber button square transparent in Classic

a+ per talk in #seamonkey channel :)
Attachment #205347 - Flags: approval-seamonkey1.0+

Comment 9

12 years ago
(In reply to comment #6)
> (From update of attachment 205347 [details] [diff] [review] [edit])
> sr=me given that two people have tried it (e.g. Mnyromyr and stefanh).
> 

Yeah, this fixes the issue with the grey square. My only complaint is that since the throbber is of such low quality (heavily compressed) and the toolbar's background is light the tail is pretty much invisible. I do think that the grey square should go, so this is the right fix. But, can we produce a throbber of better quality?
(Assignee)

Comment 10

12 years ago
Eyal, Stefan: Please file new bugs for other enhancements that are not part of the regression being fixed here. (Even though I think that a button hover rectangle around the throbber is really WONTFIX.)
(Assignee)

Comment 11

12 years ago
Checked in on trunk and branch.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

12 years ago
Keywords: fixed1.8
(Assignee)

Comment 12

12 years ago
Checked in on MOZILLA_1_8_0_BRANCH.
You need to log in before you can comment on or make changes to this bug.