Closed
Bug 319656
Opened 19 years ago
Closed 19 years ago
Toolkit code assumes document.firstChild is the root element
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: jason.barnabe, Assigned: jason.barnabe)
References
Details
Attachments
(1 file)
|
2.85 KB,
patch
|
mconnor
:
first-review+
|
Details | Diff | Splinter Review |
Bug 319654 is about adding processing instructions in XUL to the DOM tree. When
that happens, any code that thinks document.firstChild is the document element
will break. We need to change it to document.documentElement.
|
Assignee | |
Comment 1•19 years ago
|
||
(Does this need two reviews?)
Attachment #205505 -
Flags: first-review?
|
|
Assignee | |
Updated•19 years ago
|
Attachment #205505 -
Flags: first-review? → first-review?(mconnor)
|
||
Updated•19 years ago
|
Attachment #205505 -
Flags: first-review?(mconnor) → first-review+
|
||
Comment 2•19 years ago
|
||
mozilla/toolkit/content/contentAreaUtils.js; new revision: 1.82;
mozilla/toolkit/content/charsetOverlay.js; new revision: 1.11;
Status: NEW → RESOLVED
Closed: 19 years ago
OS: Linux → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha1
I've created bug 322520 for xpfe ones of this but what about:
/browser/base/content/browser.js, line 3044 -- var wintype = document.firstChild.getAttribute('windowtype');
/browser/base/content/browser.js, line 5257 -- switch (document.firstChild.getAttribute('windowtype')) {
?
|
|
||
Comment 4•19 years ago
|
||
(In reply to comment #3)
> I've created bug 322520 for xpfe ones of this but what about:
> /browser/base/content/browser.js, line 3044 -- var wintype =
> document.firstChild.getAttribute('windowtype');
> /browser/base/content/browser.js, line 5257 -- switch
> (document.firstChild.getAttribute('windowtype')) {
That's bug 319655.
You need to log in
before you can comment on or make changes to this bug.
Description
•