319730 - No events found if a string typed into the search bar contains upper-case letters

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Ilja Sekler]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20051130 Firefox/1.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051206 Mozilla Sunbird/0.3a1+

If a calendar contains an $Event (f.e. "Dinner"), searching for $Event ("Dinner) using the Search Bar shows no matches, while searching for $event ("dinner") finds and displays the event. 

Reproducible: Always

Steps to Reproduce:
1. Type a string matching an existing event, that contains upper-case letters, into the Search Bar.
Actual Results:  
no matches are found

Expected Results:  
the matching event should be display in the list, the search funktion shouldn't be case-sensitive.

Reproduced also with the official win32 nightly build from 2005-12-08, not OS-dependant.

Comment 1

[Ilja Sekler]

Attachment: an iCalendar file containing an event "Dinner"

Comment 2

[Joey Minta]

Confirmed.  Patch coming as soon as cvs is back up after the server move.

Comment 3

[Joey Minta]

Attachment: use toLowerCase

We change the event's properties to lower case, but not the search text.  This patch makes both user lower-case only, effectively making the search box case-insensitive.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 205444 [details] [diff] [review]
use toLowerCase

I don't know how long .toLowerCase() takes, but it seems to be an obvious optimization to do it once, instead of 5*n (n=number of events)

Comment 5

[Joey Minta]

Attachment: faster

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 205480 [details] [diff] [review]
faster

r=mvl

Comment 7

[Joey Minta]

patch checked in