319821 - Chatzilla code assumes document.firstChild is the root element

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Jason Barnabe (np)]

Bug 319654 is about adding processing instructions in XUL to the DOM tree. When
that happens, any code that thinks document.firstChild is the document element
will break. We need to change it to document.documentElement.

/extensions/irc/js/lib/command-manager.js, line 259 --
document.firstChild.appendChild (parentElem);

Comment 1

[James Ross]

Attachment: document.firstChild --> document.documentElement

I assume this is what you expect it to be changed to?

Comment 2

[Samuel Sieb]

Comment on attachment 205509 [details] [diff] [review]
document.firstChild --> document.documentElement

has documentElement always existed?  we won't break any old versions?

Comment 3

[Jason Barnabe (np)]

document.documentElement is DOM Level 1 and has been supported since at least 2001.

Comment 4

[James Ross]

Checked in --> FIXED.

Comment 5

[[e-mail]]

Comment on attachment 205509 [details] [diff] [review]
document.firstChild --> document.documentElement

Nit: if you were going to tweak the parentElem line you could have used parentElem.id = "dynamic-keys";