Closed
Bug 319822
Opened 19 years ago
Closed 19 years ago
JavaScript Debugger assumes document.firstChild is the root element
Categories
(Other Applications Graveyard :: Venkman JS Debugger, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jason.barnabe, Assigned: iannbugzilla)
References
Details
Attachments
(1 file)
|
966 bytes,
patch
|
rginda
:
review+
|
Details | Diff | Splinter Review |
Bug 319654 is about adding processing instructions in XUL to the DOM tree. When that happens, any code that thinks document.firstChild is the document element will break. We need to change it to document.documentElement. /extensions/venkman/resources/content/command-manager.js, line 235 -- document.firstChild.appendChild (parentElem);
Changes document.firstChild to document.documentElement
Attachment #207671 -
Flags: review? → review?(rginda)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 207671 [details] [diff] [review] Simple patch v0.1 (Checked into trunk) r=rginda
Attachment #207671 -
Flags: review?(rginda) → review+
Comment on attachment 207671 [details] [diff] [review] Simple patch v0.1 (Checked into trunk) Checking in (trunk) command-manager.js; new revision: 1.18; previous revision: 1.17 done
Attachment #207671 -
Attachment description: Simple patch v0.1 → Simple patch v0.1 (Checked into trunk)
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•