319907 - Disable 'overflow' for table row groups

Status: RESOLVED INVALID

(Core :: Layout: Tables, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Currently we allow table row groups to scroll; nsCSSFrameConstructor::ConstructTableRowGroupFrame can create a scrollframe. But 'overflow' does not apply to table row groups according to CSS2.1, so we should probably remove this code. How badly is this going to break people?

Comment 1

[Boris Zbarsky [:bzbarsky]]

https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&short_desc_type=allwordssubstr&short_desc=tbody+overflow&long_desc_type=substring&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&status_whiteboard_type=allwordssubstr&status_whiteboard=&keywords_type=allwords&keywords=&resolution=DUPLICATE&resolution=---&emailassigned_to1=1&emailtype1=exact&email1=&emailassigned_to2=1&emailreporter2=1&emailqa_contact2=1&emailtype2=exact&email2=&bugidtype=include&bug_id=&votes=&chfieldfrom=&chfieldto=Now&chfieldvalue=&cmdtype=doit&order=Reuse+same+sort+as+last+time&field0-0-0=noop&type0-0-0=noop&value0-0-0=  shows some bugs people have filed about overflow:auto on <tbody>; this is apparently used in some circles to create a fixed-height table with a fixed header and scrolling body...

That said, Safari doesn't support it as of version 1.0, and Opera 8 doesn't support it.  So I think it's safe enough to nuke it.  I just wish we had for Gecko 1.8.  :(

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Maybe we should get CSS2.1 changed instead.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We've supported this for ages, and it's important for a major (perhaps even primary) use case for row groups, as described in HTML4 chapter 11 (search for "scroll").  I think we should probably keep it.

Comment 4

[Bernd]

I go with Davids comment, we shouldn't break html4 only due to css 2.1 which has removed the attribute. We have this since 1999, I did not expect that overflow does not apply.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Okay fine, but "someone" better fix CSS2.1!