320008 - e4x - quote escaped wrongly, works as expected in rhino.

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[simon]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: xpcshell; built on Nov 26 2005 at 11:41:16

see test code

Reproducible: Always

Steps to Reproduce:
1.  print (new XML("<hello a='\"' />").toXMLString());
2.
3.

Actual Results:  
<hello a="&amp;quot;"/>


Expected Results:  
<hello a="&quot;"/>


works as expected in rhino

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

I see this. Are we escaping twice?

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Yes, we are

In the case that we're in one of the XML constructors, we're not going to reparse the XML before escaping it again, so we shouldn't escape it here.

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 206129 [details] [diff] [review]
Yes, we are

r=me, thanks.

1.8.0 fodder?  Certainly 1.8 (we may end up just releasing a SpiderMonkey 1.7 to the 1.8 branch -- dig the numerology!).

/be

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.

Comment 5

[Bob Clary [:bc] (inactive)]

Checking in 13.4.2.js;
/cvsroot/mozilla/js/tests/e4x/XML/13.4.2.js,v  <--  13.4.2.js
new revision: 1.4; previous revision: 1.3

Comment 6

[Bob Clary [:bc] (inactive)]

v windows/linux/mac

Comment 7

[Brendan Eich [:brendan]]

Comment on attachment 206129 [details] [diff] [review]
Yes, we are

Another well-baked E4X fix for a bug without a workaround.  Safe as anything, and since E4X is new I'd like to get this in sooner, so that E4X adopters have a fix from 1.5.0.1 onward.

/be

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 206129 [details] [diff] [review]
Yes, we are

a=dveditz

Comment 9

[Bob Clary [:bc] (inactive)]

fixed on both branches according to bonsai:

2006-01-10 21:07	brendan%mozilla.org 	mozilla/ js/ src/ jsscan.c 	3.81.2.7.2.4 	MOZILLA_1_8_0_BRANCH  	1/1  	Fix for 320008, a=dveditz.

2006-01-10 21:07	brendan%mozilla.org 	mozilla/ js/ src/ jsscan.c 	3.81.2.11 	MOZILLA_1_8_BRANCH  	1/1  	Fix for 320008, a=dveditz.

Comment 10

[Jay Patel [:jay]]

v.fixed on 1.8.0.1 with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1.  Test code in comment #0 shows the correct results when run in JS console with:
alert(new XML("<hello a='\"' />").toXMLString());

Comment 11

[Bob Clary [:bc] (inactive)]

v 2006-01-11 1.8.0.1, 1.8.1, trunk windows/linux/mac