320210 - nsAppRunner doesnt compile without xpinstall

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Anand Aiyer]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322)
Build Identifier: 

MOZ_XPINSTALL not defined around xpinstall specific areas

Reproducible: Always

Steps to Reproduce:

Comment 1

[Anand Aiyer]

Attachment: wrap xpinstall specific areas around MOZ_XPINSTALL ifdefs

Comment 2

[Nickolay_Ponomarev]

Attachment: patch from reporter

CVS diff of the above patch (didn't test it myself).

aaiyer: you should attach CVS diff and request reviews to get the patch into tree.

Comment 3

[Nickolay_Ponomarev]

Oops, just noticed - bug 198584.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Checked in on the trunk. Thanks for the patch Anand!
mozilla/toolkit/xre/nsAppRunner.cpp; new revision: 1.124;

Comment 5

[cls]

*** Bug 234827 has been marked as a duplicate of this bug. ***

Comment 6

[Matthew (lilmatt) Willis]

Comment on attachment 208037 [details] [diff] [review]
patch from reporter

This is preventing us from losing xpcom/obsolete when building Sunbird on 1.8 branch

Comment 7

[Matthew (lilmatt) Willis]

Reopening to see if we can get this on MOZILLA_1_8_BRANCH without breaking the world.

Comment 8

[Benjamin Smedberg]

Who's "we"? Nobody except for small devices should be disabling xpinstall, certainly not sunbird.

Comment 9

[Matthew (lilmatt) Willis]

(In reply to comment #8)
> Who's "we"? Nobody except for small devices should be disabling xpinstall,
> certainly not sunbird.

We = Sunbird.

Okay. So we can't lose xpcom-obsolete from the branch then since xpinstall claims to require xpcom-obsolete. 

Let me know if I'm missing something.

Removing br? and -> back to FIXED

Comment 10

[Matthew (lilmatt) Willis]

(In reply to comment #9)
> So we can't lose xpcom-obsolete from the branch then since xpinstall
> claims to require xpcom-obsolete. 

That should be "from the Sunbird branch build"