Last Comment Bug 320245 - Package app icons in unix installer
: Package app icons in unix installer
Status: RESOLVED FIXED
: fixed1.8
Product: SeaMonkey
Classification: Client Software
Component: Installer (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: ---
Assigned To: Robert Kaiser
: installer
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-12-14 06:32 PST by Robert Kaiser
Modified: 2008-07-31 02:13 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
add app icons to package list (1.31 KB, patch)
2005-12-14 06:35 PST, Robert Kaiser
ajschult: review+
neil: superreview+
csthomas: approval‑seamonkey1.0+
Details | Diff | Splinter Review

Description Robert Kaiser 2005-12-14 06:32:31 PST
I just came across the fact that neither the default*.xpm images nor the new seamonkey.png are packaged into our Linux installer and need to be added to the packaging list.
Comment 1 Robert Kaiser 2005-12-14 06:35:05 PST
Created attachment 205826 [details] [diff] [review]
add app icons to package list

Here's the patch, actually a trivial issue of just adding those images to packages-unix...
Comment 2 Andrew Schultz 2005-12-14 10:19:32 PST
Comment on attachment 205826 [details] [diff] [review]
add app icons to package list

are there files in chrome/icons/default we don't want packaged?  if not, should we just do *?
(this is fine for now)
Comment 3 Robert Kaiser 2005-12-14 15:17:36 PST
(In reply to comment #2)
> (From update of attachment 205826 [details] [diff] [review] [edit])
> are there files in chrome/icons/default we don't want packaged?  if not, should
> we just do *?
> (this is fine for now)

The reason we don't do * is because not all of them belong into browser.xpi, some belong into mailnews, chatzilla, venkman, inspector etc.
Comment 4 Robert Kaiser 2005-12-14 15:18:53 PST
Umm, forgot to note in the last comment that I checked this in on trunk and 1.8 branch.

Note You need to log in before you can comment on or make changes to this bug.