320320 - Should only be able to open one preference/options dialog per extension.

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Jason Barnabe (np)]

Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9a1) Gecko/20051208 Firefox/1.6a1

Currently, you can open many preference dialogs for the same extension. This is confusing and can lead to changes being overwritten if the dialogs are closed in the wrong order. We should only open one preference dialog per extension.

Comment 1

[Jason Barnabe (np)]

Attachment: patch

This puts the extension's URI in the openDialog's name argument to make sure only one dialog gets opened.

Comment 2

[Nickolay_Ponomarev]

(Note that this bug applies only to systems with instantApply=true)

I think it would be better to find an existing window and focus it instead of reloading the document of an existing window, which is what this patch does. Unfortunately EM doesn't know the windowtype of the options window, so the best way to do it, which I can think of, is to enumerate open windows and check their URIs.

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 205911 [details] [diff] [review]
patch

Yeah, this isn't quite right.  What we really need to do is make sure we set an appropriate window type, set a unique window id, and iterate looking for that.  Yes, this isn't simple and fast, but for this type of action its the Right Thing(tm)

Comment 4

[Robert Strong (they/them - no direct email)]

Fixed on trunk by the checkin of bug 329045

Comment 5

[Robert Strong (they/them - no direct email)]

Fixed on trunk by the checkin of bug 329045