320334 - Make never-overridden methods of nsIMAPGenericParser non-virtual and concatenate error flags.

Status: VERIFIED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Hans-Andreas Engel]

The following methods in |nsIMAPGenericParser| are never overridden, make them non-virtual.
   SetConnected
   ContinueParse
   skip_to_CRLF
   skip_to_close_paren
   CreateString
   CreateAstring
   CreateNilString
   CreateLiteral
   CreateAtom
   CreateQuoted
   CreateParenGroup

Also, merge the status flags |nsIMAPGenericParser::fDisconnected| and |nsIMAPGenericParser::fSyntaxError|; this simplifies the often-invoked method |nsIMAPGenericParser::ContinueParse()|.

Finally, do no longer include "nsIMAPGenericParser.h" in nsIMAPNamespace.cpp and nsImapUrl.cpp.

Comment 1

[Hans-Andreas Engel]

Attachment: Make never-overridden methods non-virtual etc.

Comment 2

[David :Bienvenu]

Comment on attachment 205921 [details] [diff] [review]
Make never-overridden methods non-virtual etc.

thx for the patch.

Instead of this:

  if (connected)
+      fParserState = fParserState & ~stateDisconnectedFlag;
+  else
+      fParserState = fParserState | stateDisconnectedFlag;
 }
 
can you do something like
fParserState |= stateDisconnectedFlag; 

and 

fParserState &= ~stateDisconnectedFlag;

Comment 3

[Hans-Andreas Engel]

Attachment: Make never-overridden methods non-virtual etc. (v2)

Simplified code as suggested in Comment 2, thank you David.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

David landed this 2005-12-19 09:27 PDT.  David: can you mark review+ and FIXED?  Thanks

Comment 5

[David :Bienvenu]

Comment on attachment 206019 [details] [diff] [review]
Make never-overridden methods non-virtual etc. (v2)

thx, Hans-Andreas

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED via LXR (and heavy IMAP usage/testing since its landing)

1.15	bienvenu%nventure.com	2005-12-19 09:27	 	fix 320334 make non-overridden methods non-virtual, patch by [e-mail], r/sr=bienvenu