320402 - Bookmarks with long titles have their title "cut off" in Bookmark Bar

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Håkan Waara]

This is on Camino trunk.

Steps to reproduce:

1. Create a bookmark and put it on the bookmark toolbar.
2. Name it something longer than 22 characters
3. The title is cut off where the next bookmark item begins.

See the screenshot. I measured, and in my case the item is only allowed to be about 22 chars long.

Comment 1

[Håkan Waara]

Attachment: Screenshot of my bookmark bar

The full title of the bookmark item in the middle of the picture is "SomaFM: Listener-Supported, Commercial-Free Internet Radio".

It's cut off to only show "SomaFM: Listener-Suppo".

Comment 2

[Mike Pinkerton (not reading bugmail)]

what's your suggestion? that we allow them to be as long as they want?

Comment 3

[Håkan Waara]

Yes. If I want them to be smaller, I just edit the title. This is how it's handled in Firefox, IE and other browsers. Safari seems to truncate in the middle, but this is just weird IMHO.

Comment 4

[Håkan Waara]

Ok, so concensus on IRC was that we probably should stick to status quo. However:

* when dragging a URL to the toolbar, we should pop up a "Rename" dialog similar to what Safari does. -> bug 320410

One remaining question for this bug: how about at least truncating too long bookmark titles?

Comment 5

[Mike Pinkerton (not reading bugmail)]

any reason why we never used an ellipsis in the first place? just wondering.

should we end-truncate? middle truncate? not bother?

Comment 6

[Stuart Morgan]

Attachment: fix

This has bugged me for a long time, and it's dirt simple to fix for 10.4+ (the trunk version of this is a one-liner, since we don't have to worry about the SDK or the runtime check)

Comment 7

[Håkan Waara]

Comment on attachment 276895 [details] [diff] [review]
fix

For the record: since we have an infinitely-long bookmarks bar anyways, I would also be fine with allowing bookmark titles to be long, but this is much better than status quo.

Comment 8

[Stuart Morgan]

Landed on trunk and MOZILLA_1_8_BRANCH.