320437 - Spellchecking menu checkboxes don't work

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Dave Townsend [:mossop]]

The spellchecking UI introduced in bug 302050 has problems on the menu items that should appear to be checked.

Patch coming.

Comment 1

[Dave Townsend [:mossop]]

Attachment: Make menuitems checkbox type

This makes the menu items for enabling spell checking and the dictionary list checkbox type.

Ben reviewed the original frontend patch so I guess this is his territory.

Comment 2

[Brett Wilson]

Thanks for finding this.

You'll also have to fix the "enabled" menuitem in
toolkit/content/widgets/textbox.xml in input-box-contextmenu
This is the context menu used by chrome.

Comment 3

[Dave Townsend [:mossop]]

Attachment: Makes context menu items checkboxes where appropriate

Thanks, missed that.

Added checkbox type to toolkit textbox context menu.

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 206005 [details] [diff] [review]
Makes context menu items checkboxes where appropriate

mconnor suggested that you could review this.

Comment 5

[Brett Wilson]

*** Bug 325819 has been marked as a duplicate of this bug. ***

Comment 6

[Brett Wilson]

Comment on attachment 206005 [details] [diff] [review]
Makes context menu items checkboxes where appropriate

Looks good

Comment 7

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/content/widgets/textbox.xml; new revision: 1.28;
mozilla/toolkit/content/inlineSpellCheckUI.js; new revision: 1.2;
mozilla/browser/base/content/browser-context.inc; new revision: 1.17;

Comment 8

[Brett Wilson]

Comment on attachment 206005 [details] [diff] [review]
Makes context menu items checkboxes where appropriate

See bug 329668 for tracking the branch landing of the spellchecker.

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 206005 [details] [diff] [review]
Makes context menu items checkboxes where appropriate

a=[e-mail]

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv