320439 - Attachments still download when "Display Attachments Inline" deselected and "Wait x to Mark a Message As Read" selected.

Status: VERIFIED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Michael Hovis]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7

When "Display Attachments Inline" is not selected and "Wait n seconds to mark a message as read" is selected, the attachments will alays download.

Reproducible: Always

Steps to Reproduce:
1.View->Display Attachments Inline is NOT checked
2.Tools->Options->Advanced "Wait n seconds to mark a message as read" is checked.
3.Select a message w/ a large attachment
4 [review].Ensure you're using an IMAP4rev1 server.

Actual Results:  
A download of all attachments will occur w/ every selection of that message.


When "Display attachments inline" is disabled - no attachments should download regardless of the other setting.

Comment 1

[Michael Hovis]

Attachment: Enables trytochunk and BODYSTRUCTURE, also Enabled peeks to occur to prevent premature /seen

This patch enables messages w/ attachments to only download completely if the option to display inline attachments is enabled.

Comment 2

[David :Bienvenu]

Comment on attachment 205997 [details] [diff] [review]
Enables trytochunk and BODYSTRUCTURE, also Enabled peeks to occur to prevent premature /seen

Mike, can you explain why we need this code now:

+      if (endByte > 0)
+      {
+        // if we are retrieving chunks
+        char *byterangeString = PR_smprintf("<%ld.%ld>",startByte,endByte);
+        if (byterangeString)
+        {
+          commandString.Append(byterangeString);
+          PR_Free(byterangeString);
+        }
+      }

Comment 3

[Michael Hovis]

(In reply to comment #2)
> (From update of attachment 205997 [details] [diff] [review] [edit])
> Mike, can you explain why we need this code now:
> 
> +      if (endByte > 0)
> +      {
> +        // if we are retrieving chunks
> +        char *byterangeString = PR_smprintf("<%ld.%ld>",startByte,endByte);
> +        if (byterangeString)
> +        {
> +          commandString.Append(byterangeString);
> +          PR_Free(byterangeString);
> +        }
> +      }
> 


This code allows FetchTryChunk call to get into that particular portion of the case statement and still allow information about the attachments/body to be retrieved.

Comment 4

[David :Bienvenu]

Comment on attachment 205997 [details] [diff] [review]
Enables trytochunk and BODYSTRUCTURE, also Enabled peeks to occur to prevent premature /seen

thx, Mike.

Comment 5

[David :Bienvenu]

*** Bug 342717 has been marked as a duplicate of this bug. ***

Comment 6

[Magnus Melin [:mkmelin]]

This was also checked in on branch (2006-02-04 14:45).