Closed Bug 320449 Opened 15 years ago Closed 15 years ago

Make properties of GRE_GetGREPathWithProperties useful

Categories

(Toolkit Graveyard :: XULRunner, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.8rc1

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

(Keywords: fixed1.8.0.1, fixed1.8.1)

Attachments

(2 files)

The "properties" of GRE_GetGREPathWithProperties is currently unused, and it should be because we're probably going to end up with XULRunner GRE 1.8 and seamonkey GRE 1.8.

So I've added two properties:

xulrunner=true (this GRE has a xulrunner binary)
javaxpcom=1 (this GRE supports javaxpcom version 1)

I know that there are other useful properties that could be added (ABI, graphics toolkit), but I couldn't find a quick and simple way to get all the data I wanted so I'd like to stick with these two for 1.8.
Attachment #206010 - Flags: first-review?(darin)
Priority: -- → P1
Comment on attachment 206010 [details] [diff] [review]
xulrunner=true and javaxpcom=1

How about "javaxpcomversion" or "javaxpcom-version" or something along those lines to make it clear that the property's value is a version field.  what are the rules for parsing that version field?  do we assume dotted notation?  why not "1.0.0.0" to make that very clear?
We do not parse the field (currently): it's just a string. I'm happy with javaxpcom-version if you think that's better.
Comment on attachment 206010 [details] [diff] [review]
xulrunner=true and javaxpcom=1

r=darin

I think NS_ARRAY_LENGTH should be moved into nscore.h ;)
Attachment #206010 - Flags: first-review?(darin) → first-review+
> We do not parse the field (currently): it's just a string. I'm happy with
> javaxpcom-version if you think that's better.

It doesn't really matter that much to me.  I was just thinking that someone
else might try to parse these values :-/
This was a logic error in the windows glue that I didn't catch until testing these properties... it won't affect ffox/tbird because they don't use the GRE/glue.
Attachment #206085 - Flags: first-review+
Attachment #206085 - Flags: approval1.8.1?
Attachment #206085 - Flags: approval1.8.0.1?
Comment on attachment 206010 [details] [diff] [review]
xulrunner=true and javaxpcom=1

xulrunner-only
Attachment #206010 - Flags: approval1.8.1?
Attachment #206010 - Flags: approval1.8.0.1?
Fixed on trunk. I did not move NS_ARRAY_LENGTH because I want to get this on branches with as little pain as possible, that can be done later.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Blocks: 320574
Comment on attachment 206085 [details] [diff] [review]
urgh, windows glue is wrong

Please consider for 1.8.1 - 1.8.0.1 is for major security and crash issues only.
Attachment #206085 - Flags: approval1.8.0.1? → approval1.8.0.1-
Comment on attachment 206085 [details] [diff] [review]
urgh, windows glue is wrong

Re-requesting approval, this does not affect ff/tbird which do not use the GRE-finding functions, it only affects xulrunner GRE-finding.
Attachment #206085 - Flags: approval1.8.0.1- → approval1.8.0.1?
Comment on attachment 206010 [details] [diff] [review]
xulrunner=true and javaxpcom=1

a=drivers
Attachment #206010 - Flags: approval1.8.1?
Attachment #206010 - Flags: approval1.8.1+
Attachment #206010 - Flags: approval1.8.0.1?
Attachment #206010 - Flags: approval1.8.0.1+
Comment on attachment 206085 [details] [diff] [review]
urgh, windows glue is wrong

a=drivers
Attachment #206085 - Flags: approval1.8.1?
Attachment #206085 - Flags: approval1.8.1+
Attachment #206085 - Flags: approval1.8.0.1?
Attachment #206085 - Flags: approval1.8.0.1+
Fixed on MOZILLA_1_8_BRANCH and MOZILLA_1_8_0_BRANCH.
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.