If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Make properties of GRE_GetGREPathWithProperties useful

RESOLVED FIXED in mozilla1.8rc1

Status

Toolkit Graveyard
XULRunner
P1
normal
RESOLVED FIXED
12 years ago
2 years ago

People

(Reporter: Benjamin Smedberg, Assigned: Benjamin Smedberg)

Tracking

({fixed1.8.0.1, fixed1.8.1})

unspecified
mozilla1.8rc1
fixed1.8.0.1, fixed1.8.1
Dependency tree / graph

Details

Attachments

(2 attachments)

(Assignee)

Description

12 years ago
The "properties" of GRE_GetGREPathWithProperties is currently unused, and it should be because we're probably going to end up with XULRunner GRE 1.8 and seamonkey GRE 1.8.

So I've added two properties:

xulrunner=true (this GRE has a xulrunner binary)
javaxpcom=1 (this GRE supports javaxpcom version 1)

I know that there are other useful properties that could be added (ABI, graphics toolkit), but I couldn't find a quick and simple way to get all the data I wanted so I'd like to stick with these two for 1.8.
(Assignee)

Comment 1

12 years ago
Created attachment 206010 [details] [diff] [review]
xulrunner=true and javaxpcom=1
Attachment #206010 - Flags: first-review?(darin)
(Assignee)

Updated

12 years ago
Priority: -- → P1

Comment 2

12 years ago
Comment on attachment 206010 [details] [diff] [review]
xulrunner=true and javaxpcom=1

How about "javaxpcomversion" or "javaxpcom-version" or something along those lines to make it clear that the property's value is a version field.  what are the rules for parsing that version field?  do we assume dotted notation?  why not "1.0.0.0" to make that very clear?
(Assignee)

Comment 3

12 years ago
We do not parse the field (currently): it's just a string. I'm happy with javaxpcom-version if you think that's better.

Comment 4

12 years ago
Comment on attachment 206010 [details] [diff] [review]
xulrunner=true and javaxpcom=1

r=darin

I think NS_ARRAY_LENGTH should be moved into nscore.h ;)
Attachment #206010 - Flags: first-review?(darin) → first-review+

Comment 5

12 years ago
> We do not parse the field (currently): it's just a string. I'm happy with
> javaxpcom-version if you think that's better.

It doesn't really matter that much to me.  I was just thinking that someone
else might try to parse these values :-/
(Assignee)

Comment 6

12 years ago
Created attachment 206085 [details] [diff] [review]
urgh, windows glue is wrong

This was a logic error in the windows glue that I didn't catch until testing these properties... it won't affect ffox/tbird because they don't use the GRE/glue.
Attachment #206085 - Flags: first-review+
Attachment #206085 - Flags: approval1.8.1?
Attachment #206085 - Flags: approval1.8.0.1?
(Assignee)

Comment 7

12 years ago
Comment on attachment 206010 [details] [diff] [review]
xulrunner=true and javaxpcom=1

xulrunner-only
Attachment #206010 - Flags: approval1.8.1?
Attachment #206010 - Flags: approval1.8.0.1?
(Assignee)

Comment 8

12 years ago
Fixed on trunk. I did not move NS_ARRAY_LENGTH because I want to get this on branches with as little pain as possible, that can be done later.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Updated

12 years ago
Blocks: 302101

Updated

12 years ago
Blocks: 320574

Comment 9

12 years ago
Comment on attachment 206085 [details] [diff] [review]
urgh, windows glue is wrong

Please consider for 1.8.1 - 1.8.0.1 is for major security and crash issues only.
Attachment #206085 - Flags: approval1.8.0.1? → approval1.8.0.1-
(Assignee)

Comment 10

12 years ago
Comment on attachment 206085 [details] [diff] [review]
urgh, windows glue is wrong

Re-requesting approval, this does not affect ff/tbird which do not use the GRE-finding functions, it only affects xulrunner GRE-finding.
Attachment #206085 - Flags: approval1.8.0.1- → approval1.8.0.1?
(Assignee)

Comment 11

12 years ago
Comment on attachment 206010 [details] [diff] [review]
xulrunner=true and javaxpcom=1

a=drivers
Attachment #206010 - Flags: approval1.8.1?
Attachment #206010 - Flags: approval1.8.1+
Attachment #206010 - Flags: approval1.8.0.1?
Attachment #206010 - Flags: approval1.8.0.1+
(Assignee)

Comment 12

12 years ago
Comment on attachment 206085 [details] [diff] [review]
urgh, windows glue is wrong

a=drivers
Attachment #206085 - Flags: approval1.8.1?
Attachment #206085 - Flags: approval1.8.1+
Attachment #206085 - Flags: approval1.8.0.1?
Attachment #206085 - Flags: approval1.8.0.1+
(Assignee)

Comment 13

12 years ago
Fixed on MOZILLA_1_8_BRANCH and MOZILLA_1_8_0_BRANCH.
Keywords: fixed1.8.0.1, fixed1.8.1
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.