The default bug view has changed. See this FAQ.

Fix NewChannel impls to handle null in argument

RESOLVED FIXED

Status

()

Core
Networking
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

({fixed1.8.0.2, fixed1.8.1})

Trunk
PowerPC
Mac OS X
fixed1.8.0.2, fixed1.8.1
Points:
---
Bug Flags:
blocking1.8.0.2 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nvn-dl])

Attachments

(1 obsolete attachment)

(Assignee)

Description

11 years ago
 
(Assignee)

Comment 1

11 years ago
Created attachment 206067 [details] [diff] [review]
handle null pointers
Attachment #206067 - Flags: superreview?(darin)
Attachment #206067 - Flags: review?(darin)

Updated

11 years ago
Attachment #206067 - Flags: superreview?(darin)
Attachment #206067 - Flags: superreview+
Attachment #206067 - Flags: review?(darin)
Attachment #206067 - Flags: review+

Updated

11 years ago
Blocks: 320065
(Assignee)

Comment 2

11 years ago
Comment on attachment 206067 [details] [diff] [review]
handle null pointers

mozilla/netwerk/protocol/viewsource/src/nsViewSourceHandler.cpp 	1.13
mozilla/netwerk/protocol/keyword/src/nsKeywordProtocolHandler.cpp 	1.39
mozilla/netwerk/protocol/gopher/src/nsGopherHandler.cpp 	1.21
mozilla/netwerk/protocol/res/src/nsResProtocolHandler.cpp 	1.65
mozilla/netwerk/protocol/ftp/src/nsFtpProtocolHandler.cpp 	1.87
mozilla/browser/components/places/src/nsAnnoProtocolHandler.cpp 	1.3
mozilla/content/html/document/src/nsWyciwygProtocolHandler.cpp 	1.8
mozilla/directory/xpcom/base/src/nsLDAPProtocolHandler.cpp 	1.17
mozilla/modules/libpr0n/decoders/icon/nsIconProtocolHandler.cpp 	1.16
mozilla/embedding/tests/wxEmbed/GeckoProtocolHandler.cpp 	1.10
mozilla/extensions/finger/nsFingerHandler.cpp 	1.19
mozilla/mailnews/compose/src/nsSmtpService.cpp 	1.137
mozilla/extensions/gnomevfs/nsGnomeVFSProtocolHandler.cpp 	1.9
mozilla/mailnews/local/src/nsMailboxService.cpp 	1.121
mozilla/mailnews/local/src/nsPop3Service.cpp 	1.110
mozilla/netwerk/protocol/about/src/nsAboutBlank.cpp 	1.33
mozilla/netwerk/protocol/about/src/nsAboutBloat.cpp 	1.40
mozilla/netwerk/protocol/about/src/nsAboutCache.cpp 	1.43
mozilla/netwerk/protocol/about/src/nsAboutCacheEntry.cpp 	1.31
mozilla/netwerk/protocol/about/src/nsAboutProtocolHandler.cpp 	1.42
mozilla/netwerk/protocol/about/src/nsAboutRedirector.cpp 	1.24
mozilla/mailnews/news/src/nsNntpService.cpp 	1.254
mozilla/extensions/datetime/nsDateTimeHandler.cpp 	1.17
mozilla/netwerk/protocol/data/src/nsDataHandler.cpp 	1.28
Attachment #206067 - Attachment is obsolete: true
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Flags: blocking1.8.0.2?

Comment 3

11 years ago
Comment on attachment 206067 [details] [diff] [review]
handle null pointers

timeless says this will fix bug 320065, which is, for all intensive purposes, the #1 topcrasher in 1.5. This is a very safe fix (it just adds null pointer checks to several functions), and has been on trunk about a month with no obvious regressions.
Attachment #206067 - Flags: approval1.8.1?
Attachment #206067 - Flags: approval1.8.0.2?
would this fix Bug 306767 too ?
Attachment #206067 - Flags: approval1.8.1? → branch-1.8.1?(darin)

Updated

11 years ago
Attachment #206067 - Flags: branch-1.8.1?(darin) → branch-1.8.1+
Flags: blocking1.8.0.2? → blocking1.8.0.2+
Comment on attachment 206067 [details] [diff] [review]
handle null pointers

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #206067 - Flags: approval1.8.0.2? → approval1.8.0.2+
(Assignee)

Comment 6

11 years ago
Comment on attachment 206067 [details] [diff] [review]
handle null pointers

MOZILLA_1_8_0_BRANCH:
mozilla/content/html/document/src/nsWyciwygProtocolHandler.cpp 	1.7.36.1
mozilla/directory/xpcom/base/src/nsLDAPProtocolHandler.cpp 	1.16.36.1
mozilla/embedding/tests/wxEmbed/GeckoProtocolHandler.cpp 	1.8.12.1.4.1
mozilla/extensions/datetime/nsDateTimeHandler.cpp 	1.16.28.1
mozilla/extensions/finger/nsFingerHandler.cpp 	1.18.28.1
mozilla/extensions/gnomevfs/nsGnomeVFSProtocolHandler.cpp 	1.7.16.1
mozilla/mailnews/compose/src/nsSmtpService.cpp 	1.135.10.1
mozilla/mailnews/local/src/nsMailboxService.cpp 	1.114.8.3.2.1
mozilla/mailnews/local/src/nsPop3Service.cpp 	1.109.10.1
mozilla/mailnews/news/src/nsNntpService.cpp 	1.253.10.1
mozilla/modules/libpr0n/decoders/icon/nsIconProtocolHandler.cpp 	1.15.16.1
mozilla/netwerk/protocol/about/src/nsAboutBlank.cpp 	1.30.20.1.4.1
mozilla/netwerk/protocol/about/src/nsAboutBloat.cpp 	1.38.18.1.4.1
mozilla/netwerk/protocol/about/src/nsAboutCache.cpp 	1.39.12.1.4.1
mozilla/netwerk/protocol/about/src/nsAboutCacheEntry.cpp 	1.28.12.1.4.1
mozilla/netwerk/protocol/about/src/nsAboutCacheEntry.cpp 	1.28.12.1.4.2
mozilla/netwerk/protocol/about/src/nsAboutProtocolHandler.cpp 	1.39.2.1.2.1
mozilla/netwerk/protocol/about/src/nsAboutRedirector.cpp 	1.22.2.1.2.1
mozilla/netwerk/protocol/data/src/nsDataHandler.cpp 	1.26.26.1
mozilla/netwerk/protocol/data/src/nsDataHandler.cpp 	1.26.26.2
mozilla/netwerk/protocol/ftp/src/nsFtpProtocolHandler.cpp 	1.86.16.1
mozilla/netwerk/protocol/gopher/src/nsGopherHandler.cpp 	1.19.26.1
mozilla/netwerk/protocol/gopher/src/nsGopherHandler.cpp 	1.19.26.2
mozilla/netwerk/protocol/keyword/src/nsKeywordProtocolHandler.cpp 	1.37.26.1
mozilla/netwerk/protocol/res/src/nsResProtocolHandler.cpp 	1.64.26.1
mozilla/netwerk/protocol/viewsource/src/nsViewSourceHandler.cpp 	1.12.32.1

MOZILLA_1_8_BRANCH:
mozilla/content/html/document/src/nsWyciwygProtocolHandler.cpp 	1.7.28.1
mozilla/directory/xpcom/base/src/nsLDAPProtocolHandler.cpp 	1.16.28.1
mozilla/embedding/tests/wxEmbed/GeckoProtocolHandler.cpp 	1.8.12.2
mozilla/extensions/datetime/nsDateTimeHandler.cpp 	1.16.20.1
mozilla/extensions/finger/nsFingerHandler.cpp 	1.18.20.1
mozilla/extensions/gnomevfs/nsGnomeVFSProtocolHandler.cpp 	1.7.8.1
mozilla/mailnews/compose/src/nsSmtpService.cpp 	1.135.2.1
mozilla/mailnews/local/src/nsMailboxService.cpp 	1.114.8.5
mozilla/mailnews/local/src/nsPop3Service.cpp 	1.109.2.1
mozilla/mailnews/news/src/nsNntpService.cpp 	1.253.2.1
mozilla/modules/libpr0n/decoders/icon/nsIconProtocolHandler.cpp 	1.15.8.1
mozilla/netwerk/protocol/about/src/nsAboutBlank.cpp 	1.30.20.2
mozilla/netwerk/protocol/about/src/nsAboutBloat.cpp 	1.38.18.2
mozilla/netwerk/protocol/about/src/nsAboutCache.cpp 	1.39.12.2
mozilla/netwerk/protocol/about/src/nsAboutCacheEntry.cpp 	1.28.12.2
mozilla/netwerk/protocol/about/src/nsAboutCacheEntry.cpp 	1.28.12.3
mozilla/netwerk/protocol/about/src/nsAboutProtocolHandler.cpp 	1.39.2.2
mozilla/netwerk/protocol/about/src/nsAboutRedirector.cpp 	1.22.2.3
mozilla/netwerk/protocol/data/src/nsDataHandler.cpp 	1.26.18.1
mozilla/netwerk/protocol/data/src/nsDataHandler.cpp 	1.26.18.2
mozilla/netwerk/protocol/ftp/src/nsFtpProtocolHandler.cpp 	1.86.8.1
mozilla/netwerk/protocol/gopher/src/nsGopherHandler.cpp 	1.19.18.1
mozilla/netwerk/protocol/gopher/src/nsGopherHandler.cpp 	1.19.18.2
mozilla/netwerk/protocol/keyword/src/nsKeywordProtocolHandler.cpp 	1.37.18.1
mozilla/netwerk/protocol/res/src/nsResProtocolHandler.cpp 	1.64.18.1
mozilla/netwerk/protocol/viewsource/src/nsViewSourceHandler.cpp 	1.12.24.1
Keywords: fixed1.8.0.2, fixed1.8.1

Updated

11 years ago
Whiteboard: [nvn-dl]
You need to log in before you can comment on or make changes to this bug.