3205 - RX: plugins

Status: VERIFIED WORKSFORME

(Core Graveyard :: Plug-ins, defect, P1)

Description

[chris hofmann]

These are mostly function or method static modifiers, I bet, and therefore ok,
but please bug amusil:

Much of our non-static/global data needs to be partitioned by window,
not reachable by other windows except through statics/globals.
Therefore we're starting the hunt with statics and globals.
Please have a look at the file(s) below to see if we can improve reentrantcy
across
the code base by making modifications to:

modules/plugin/nglsrc/ns4xPlugin.h: static nsresult
modules/plugin/nglsrc/ns4xPlugin.h: static nsresult NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static nsresult NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static nsresult NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static nsresult NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static nsresult NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static nsresult NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static nsresult NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static nsresult NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static int32 NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static nsresult NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static void NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static void NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static void NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static int16 NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static void NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static uint32 NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static void NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static void NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static void NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static void NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static const char* NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static void* NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static JRIEnv* NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static jref NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static java_lang_Class* NP_EXPORT
modules/plugin/nglsrc/ns4xPlugin.h: static NPNetscapeFuncs CALLBACKS;
modules/plugin/nglsrc/ns4xPlugin.h: static nsIPluginManager *mPluginManager;
modules/plugin/nglsrc/ns4xPlugin.h: static nsIMalloc *mMalloc;

Comment 1

[leger]

Setting QA Contact to assigned engineer since this person will need to verify
that this has been done.

Comment 2

[chris hofmann]

RX tasks aren't going to make M3.
close the reentrantcy tracking tasks if this specific area has been looked at
and doesn't seem to be a problem.  Otherwise each of these areas
still need some looking at.

Comment 3

[chris hofmann]

alex, had a chance to look at this yet?

Comment 4

[Alex Musil]

I do not believe this should be a problem.  There are just calling points into
old 4x plugins.

cc'ing Patrick in case he has more input.

Comment 5

[av (gone)]

Looks like everybody agrees this should not cause any problems. Hm... How to
mark it? Worksforme?

Comment 6

[Keyser Sose]

Verified. So old i dont think it even matters.