320845 - Clicking Camino icon in dock doesn't open minimized window

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[[e-mail]]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20051219 Camino/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20051219 Camino/1.0+

A minimized window can no longer be reopened when clicking on the Camino icon in the dock.
This is using my own trunk build (the official nightly build is not out yet, so unable to test it). checkout finish: Mon Dec 19 12:47:14 CET 2005

Working as expected in the 12/18 official nightly trunk build.

Reproducible: Always

Steps to Reproduce:
1. Minimize the only window
2. Click the Camino icon in your Dock

Actual Results:  
Camino opens a new fresh window

Expected Results:  
Camino open the minimiuzed window

Comment 1

[Mike Pinkerton (not reading bugmail)]

can we get a bonsai checkin window to track down the culprit?

Comment 2

[[e-mail]]

(In reply to comment #1)
> can we get a bonsai checkin window to track down the culprit?
> 
This should be about right.
Checkins to directory /mozilla/camino between 2005-12-18 03:00 and 2005-12-19 03:45 : http://tinyurl.com/dvalz

Comment 3

[Mike Pinkerton (not reading bugmail)]

ah, looks like a regression from the getFrontmostBrowserWindow changes. This would then probably also be on the branch.

-> smfr

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I see comment 0 on the branch, too.

Comment 5

[Simon Fraser [no longer active]]

Fixed by allowing miniaturized windows to be returned by -getFrontmostBrowserWindow, and included in -browserWindows.

Checked in 1.8 branch and trunk, but not 1.8.0 yet.

Comment 6

[Samuel Sidler (old account; do not CC)]

Simon, did you land this on the 1.8.0 branch yet?

Comment 7

[Simon Fraser [no longer active]]

Yeah, i think it went over with the merge.

Comment 8

[Mark Mentovai]

Yeah, it did.  Fixing keywords.

Comment 9

[Marcia Knous [:marcia]]

Verified on the branch using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1.

Comment 10

[Samuel Sidler (old account; do not CC)]

(In reply to comment #9)
> Verified on the branch using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O;
> en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1.
> 

Marcia, please verify with a Camino build.