320854 - o.hasOwnProperty('length') lies when o has function in proto chain

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Bob Clary [:bc] (inactive)]

Spun off of bug 313570.

Comment 1

[Bob Clary [:bc] (inactive)]

I moved the length test from bug 313570 to bug 320854.

Checking in ecma_3/Object/regress-320854.js;
/cvsroot/mozilla/js/tests/ecma_3/Object/regress-320854.js,v  <--  regress-320854.js
initial revision: 1.1
done
Checking in ecma_3/Function/regress-313570.js;
/cvsroot/mozilla/js/tests/ecma_3/Function/regress-313570.js,v  <--  regress-313570.js
new revision: 1.2; previous revision: 1.1
done

Comment 2

[Brendan Eich [:brendan]]

Attachment: proposed fix

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 206321 [details] [diff] [review]
proposed fix

r=mrbkap

Comment 4

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 206321 [details] [diff] [review]
proposed fix

sr=shaver.

Comment 5

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 206321 [details] [diff] [review]
proposed fix

you know what'd be neat? mid-air protection for flags

Comment 6

[Brendan Eich [:brendan]]

Fixed.  Not important enough for 1.8.0.x, but should get into 1.8.1.  But so should almost every such fix, so I'm not sure I want to keep nominating.  For now I will, however, to make it easy to query.

/be

Comment 7

[Bob Clary [:bc] (inactive)]

verified windows/linux/mac

Comment 8

[Brendan Eich [:brendan]]

Comment on attachment 206321 [details] [diff] [review]
proposed fix

Since the fix for bug 320119 was approved, this patch could be too.  It makes a related case to-do with the built-in length property of function objects work. It's a one-line change not counting the comment.

/be

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 206321 [details] [diff] [review]
proposed fix

a=dveditz

Comment 10

[Bob Clary [:bc] (inactive)]

fixed on both branches according to bonsai:

2006-01-10 20:56	brendan%mozilla.org 	mozilla/ js/ src/ jsobj.c 	3.208.2.15 	MOZILLA_1_8_BRANCH  	16/1  	Fix for 320854, a=dveditz.

2006-01-10 20:58	brendan%mozilla.org 	mozilla/ js/ src/ jsobj.c 	3.208.2.12.2.3 	MOZILLA_1_8_0_BRANCH  	16/1  	Fix for 320854, a=dveditz.

Comment 11

[Bob Clary [:bc] (inactive)]

verified fixed 2005-01-11 builds on 1.8.0.1, 1.8.1, trunk windows/linux/mac

Comment 12

[Bob Clary [:bc] (inactive)]

no need to block 1.8.1 it is already fixed yonder.