320874 - Caret moves incorrectly when pressing left-arrow to the left of LTR text at the end of an RTL textarea which is followed by LTR text, in LTR context

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Uri Bernstein]

Just when I thought I caught them all, here's another BiDi caret bug.
I'll attach the testcase immediately.

Comment 1

[Uri Bernstein]

Attachment: testcase

Place the caret to the left of the "E" in "English" and press left-arrow.
Expected: Nothing should happen.
Actually: The caret moves to the right of the "h".

Comment 2

[Uri Bernstein]

Corrected summary, and attempted to make it somewhat more comprehensible.

Comment 3

[Uri Bernstein]

Attachment: patch

Implement the "Lock In Scroll View" mechanism (from nsLeafIterator) in nsVisualIterator.
The problem was that nsVisualIterator (and thus GetFrameFromDirection) was reaching outside the textarea - leading to wrong results.

Comment 4

[Uri Bernstein]

Attachment: patch v1.1

Oops - I forgot to initialize mLockScroll in the constructor.

Comment 5

[Uri Bernstein]

ROC, is there a reason why you haven't sr'ed this?

Comment 6

[Uri Bernstein]

(In reply to comment #5)
> ROC, is there a reason why you haven't sr'ed this?

It's probably more effective to ask this when you can actually see the question :)

Comment 7

[Uri Bernstein]

Thanks, ROC.

Checked in:
Checking in layout/base/nsFrameTraversal.cpp;
/cvsroot/mozilla/layout/base/nsFrameTraversal.cpp,v  <--  nsFrameTraversal.cpp
new revision: 3.50; previous revision: 3.49
done

Comment 8

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).