320888 - plugin's NewStream func is called twice

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Plug-ins, defect)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

Steps to reproduce:
0) Install the attached test plugin
1) Download the page at the URL, and edit it to point it to a local file of type video/mpeg (or choose a file of any mimetype and edit the plugin to use that mimetype instead).
2) Start the browser and load the page

Results:
The plugin's NewStream func is called twice. Both streams deliver the *same data*.

Here are the traces from the 2 NewStream calls:
First one:
#0  0xb3d68f51 in ?? () from /opt/gnome-2.14/lib/mozilla/plugins/libtotem_mozilla.so
#1  0xb4b9380e in ns4xPluginStreamListener::OnStartBinding (this=0x8860f10, pluginInfo=0x8749750)
    at /opt/source/mozilla/trunk-ff/mozilla/modules/plugin/base/src/ns4xPluginInstance.cpp:267
#2  0xb4ba3aa4 in nsPluginStreamListenerPeer::SetUpStreamListener (this=0x8891bf0, request=0x85d0120, aURL=0x85cff48)
    at /opt/source/mozilla/trunk-ff/mozilla/modules/plugin/base/src/nsPluginHostImpl.cpp:2444
#3  0xb4ba5a9e in nsPluginStreamListenerPeer::OnStartRequest (this=0x8891bf0, request=0x85d0120, aContext=0x0)
    at /opt/source/mozilla/trunk-ff/mozilla/modules/plugin/base/src/nsPluginHostImpl.cpp:2080
#4  0xb5e65ca8 in nsObjectLoadingContent::OnStartRequest (this=0x865b2b4, aRequest=0x85d0120, aContext=0x0)
    at /opt/source/mozilla/trunk-ff/mozilla/content/base/src/nsObjectLoadingContent.cpp:439
#5  0xb599bc5d in nsBaseChannel::OnStartRequest (this=0x85d00f0, request=0x881ae18, ctxt=0x0)
    at /opt/source/mozilla/trunk-ff/mozilla/netwerk/base/src/nsBaseChannel.cpp:529
#6  0xb59ad96f in nsInputStreamPump::OnStateStart (this=0x881ae18) at /opt/source/mozilla/trunk-ff/mozilla/netwerk/base/src/nsInputStreamPump.cpp:381
#7  0xb59ae400 in nsInputStreamPump::OnInputStreamReady (this=0x881ae18, stream=0x8823c6c)
    at /opt/source/mozilla/trunk-ff/mozilla/netwerk/base/src/nsInputStreamPump.cpp:337
#8  0xb6de24d9 in nsInputStreamReadyEvent::EventHandler (plevent=0x8819794) at /opt/source/mozilla/trunk-ff/mozilla/xpcom/io/nsStreamUtils.cpp:120
[...]

Second one:
#0  0xb3d68f51 in ?? () from /opt/gnome-2.14/lib/mozilla/plugins/libtotem_mozilla.so
#1  0xb4b9380e in ns4xPluginStreamListener::OnStartBinding (this=0x8865028, pluginInfo=0x8614fe0)
    at /opt/source/mozilla/trunk-ff/mozilla/modules/plugin/base/src/ns4xPluginInstance.cpp:267
#2  0xb4ba3aa4 in nsPluginStreamListenerPeer::SetUpStreamListener (this=0x867eca8, request=0x880a398, aURL=0x85cff48)
    at /opt/source/mozilla/trunk-ff/mozilla/modules/plugin/base/src/nsPluginHostImpl.cpp:2444
#3  0xb4ba5a9e in nsPluginStreamListenerPeer::OnStartRequest (this=0x867eca8, request=0x880a398, aContext=0x0)
    at /opt/source/mozilla/trunk-ff/mozilla/modules/plugin/base/src/nsPluginHostImpl.cpp:2080
#4  0xb599bc5d in nsBaseChannel::OnStartRequest (this=0x880a368, request=0x880f9f0, ctxt=0x0)
    at /opt/source/mozilla/trunk-ff/mozilla/netwerk/base/src/nsBaseChannel.cpp:529
#5  0xb59ad96f in nsInputStreamPump::OnStateStart (this=0x880f9f0) at /opt/source/mozilla/trunk-ff/mozilla/netwerk/base/src/nsInputStreamPump.cpp:381
#6  0xb59ae400 in nsInputStreamPump::OnInputStreamReady (this=0x880f9f0, stream=0x88f78e4)
    at /opt/source/mozilla/trunk-ff/mozilla/netwerk/base/src/nsInputStreamPump.cpp:337
#7  0xb6de24d9 in nsInputStreamReadyEvent::EventHandler (plevent=0x8860a44) at /opt/source/mozilla/trunk-ff/mozilla/xpcom/io/nsStreamUtils.cpp:120
[...]

There's almost completely identical, except that the 2nd one is missing #4 [nsObjectLoadingContent::OnStartRequest] from the first one.

This is with a trunk build from 2005-12-17. With this test plugin, I do not see this on 1.8 branch or aviary 1.0 branch, but with a real-world plugin I'm working on I'm also seeing this on the branches; I haven't figured out the differences yet.

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: dumbplugin.c

Comment 2

[strk]

I confirm the bug is still present as of version 3.0.6.
Was a problem for Gnash: https://savannah.gnu.org/bugs/?24653