Closed Bug 320901 Opened 20 years ago Closed 19 years ago

Remove reloading code, key and context menu item from help viewer

Categories

(SeaMonkey :: Help Viewer, defect)

Product:
SeaMonkey
Component:
Help Viewer
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.8.1

People

(Reporter: jwalden+fxhelp, Assigned: steffen.wilberg)

Details

(Keywords: fixed1.8.1, useless-UI)

Attachments

(1 file)

just nuke it
4.24 KB, patch
asaf
: approval-branch-1.8.1+
Details | Diff | Splinter Review
See reload() and BrowserReloadWithFlags(); at a cursory glance neither is used any more since the help viewer UI changes beyond a hidden keyboard shortcut that should probably be removed. Remote help pages don't quite work now anyway, so unless that gets fixed there's never even a reason to reload the page.
Attached patch just nuke it — — Splinter Review
Assignee: jwalden+fxhelp → steffen.wilberg
Status: NEW → ASSIGNED
Attachment #213180 - Flags: first-review?(bugs.mano)
Attachment #213180 - Flags: approval-branch-1.8.1?(bugs.mano)
Keywords: useless-UI
Target Milestone: --- → mozilla1.8.1
Comment on attachment 213180 [details] [diff] [review] just nuke it We still have a menuitem for this, see: http://lxr.mozilla.org/seamonkey/source/toolkit/components/help/content/helpContextOverlay.xul#59 If you would like to get rid of the menuitem, please talk to mconnor/beltzner first.
Attachment #213180 - Flags: first-review?(bugs.mano)
Attachment #213180 - Flags: first-review-
Attachment #213180 - Flags: approval-branch-1.8.1?(bugs.mano)
Attachment #213180 - Flags: approval-branch-1.8.1-
Comment on attachment 213180 [details] [diff] [review] just nuke it The patch gets rid of the context menu item as well.
Attachment #213180 - Flags: first-review?(mconnor)
Attachment #213180 - Flags: first-review-
Attachment #213180 - Flags: approval-branch-1.8.1?(mconnor)
Attachment #213180 - Flags: approval-branch-1.8.1-
Summary: Remove reloading code and key from help viewer → Remove reloading code, key and context menu item from help viewer
Comment on attachment 213180 [details] [diff] [review] just nuke it Beltzner, are you ok with removing the Reload context menu item from the Help Viewer?
Attachment #213180 - Flags: second-review?(beltzner)
Comment on attachment 213180 [details] [diff] [review] just nuke it Assuming this is truly useless UI, and there's no need to ever reload a page, I have no problem with removing it.
Attachment #213180 - Flags: second-review?(beltzner) → second-review+
Comment on attachment 213180 [details] [diff] [review] just nuke it There's indeed no need to reload chrome pages. We also got rid of the dialog screenshots, which were loaded remotely, before Firefox 1.5. The "Using Mozilla Firefox" document contains images of the location bar and search bar etc., but probably nobody would even notice if they were missing.
Attachment #213180 - Flags: first-review?(mconnor)
Attachment #213180 - Flags: first-review?(bugs.mano)
Attachment #213180 - Flags: approval-branch-1.8.1?(mconnor)
Attachment #213180 - Flags: approval-branch-1.8.1?(bugs.mano)
Comment on attachment 213180 [details] [diff] [review] just nuke it r+a=mano if you also remove the entity from help.dtd.
Attachment #213180 - Flags: first-review?(bugs.mano)
Attachment #213180 - Flags: first-review+
Attachment #213180 - Flags: approval-branch-1.8.1?(bugs.mano)
Attachment #213180 - Flags: approval-branch-1.8.1+
Checked in trunk and branch, with reloadCmd.label and reloadCmd.accesskey removed from mozilla/toolkit/locales/en-US/chrome/mozapps/help/help.dtd.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Flags: in-testsuite-
Product: Toolkit → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: