321237 - Make NS_OS_CURRENT_PROCESS_DIR correct for xulrunner apps

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Benjamin Smedberg]

Now that we're in 1.9, we should make NS_OS_CURRENT_PROCESS_DIR correct for xulrunner apps (it should point to the app directory, not the xulrunner directory). NS_GRE_DIR will point to the xulrunner directory.

This is probably going to be a slightly destabilizing change, because it will change what resource:/// points to in xulrunner apps (it shouldn't affect firefox that much because the xulrunner dir and the app dir are still the same).

This will help me to expose profile-management APIs to embedding apps by unifying nsXREDirProvider and nsEmbedDirProvider.

Comment 1

[Benjamin Smedberg]

Attachment: Rework NS_OS_CURRENT_PROCESS_DIR and NS_GRE_DIR, rev. 1

Comment 2

[Darin Fisher]

Hmm... we invented resource://app/ to locate resources in the xulrunner app.  Are you saying that we should deprecate that in favor of resource:/// ?

Comment 3

[Benjamin Smedberg]

Probably, yes, or at least promise that they'll always be the same. The only reason I didn't suggest this earlier is that there are probably a significant number of places in our code that use resource:/// when they actually mean to be using resource://gre/.

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 206621 [details] [diff] [review]
Rework NS_OS_CURRENT_PROCESS_DIR and NS_GRE_DIR, rev. 1

>   NS_ENSURE_ARG(aLibXULDirectory);
>-  NS_ENSURE_ARG(aAppDirectory);
>+
>+  if (!aAppDirectory)
>+    aAppDirectory = aLibXULDirectory;
Looks good. I'm curious if this change is just a nice to have or is there currently a case where this is necessary?

Comment 5

[Benjamin Smedberg]

The embedfunctions change is mostly unrelated, it just has to do with my starting to port gtkmozmebed to XRE_InitEmbedding and realizing that there are situations where there is no "application directory".

Comment 6

[Benjamin Smedberg]

Fixed on trunk.